Closed maaaaz closed 1 year ago
You know I tried this not too long ago, and failed hard ha. I'll try to revist once I have some more time. I had it up on PyPi, but it was installed like a library vs something you could execute. I need to do some more research, thanks for the link. This is def on my radar.
installed like a library vs something you could execute
: I know what you mean, yes there are some traps not fall into.
If I find some time I'll prepare the package and show you how to use it ! You will just have to upload it with your account on pypi.
I would like to help with this item as well. As I would like to use smbmap as a library and as a CLI tool.
Hey @ShawnDEvans,
I created https://pypi.org/project/smbmap/1.8.2/. Happy to add you as a maintainer if you comment your pypi handle.
This is awesome, thanks for doing this! At some point a while ago I tried to go the PyPi route and failed spectacularly at packaging it up correctly ha. So, thanks again!
-Shawn
On Sat, Mar 25, 2023 at 1:29 AM Aaron Lichtman @.***> wrote:
Hey @ShawnDEvans https://github.com/ShawnDEvans,
I created https://pypi.org/project/smbmap/1.8.2/. Happy to add you as a maintainer if you comment your pypi handle.
— Reply to this email directly, view it on GitHub https://github.com/ShawnDEvans/smbmap/issues/48#issuecomment-1483729924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6SKWEP2TNA6FZ5Y757X4DW5Z7CHANCNFSM4MKHTVYA . You are receiving this because you were mentioned.Message ID: @.***>
Thank you all
@ShawnDEvans optimally, I wouldn't be responsible for creating a new pypi release every time you cut a new release on github. Github Actions supports creating a new pypi release automatically. For you to set this up, you'd need to:
smbmap
packagepython-publish.yml
action with your PyPi API keyWould you be interested in setting this up?
I'm just thrilled you set it up once man! I'm down for taking a stab at figuring it out. Thanks for the assistance. I may reach out if I got a wall. Thanks!
On Fri, May 19, 2023, 11:33 PM Aaron Lichtman @.***> wrote:
@ShawnDEvans https://github.com/ShawnDEvans optimally, I wouldn't be responsible for creating a new pypi release every time you cut a new release on github. Github Actions supports creating a new pypi release automatically. For you to set this up, you'd need to:
- create a PyPi account
- be added as a maintainer of the smbmap package
- configure the python-publish.yml action with your PyPi API key
Would you be interested in setting this up?
— Reply to this email directly, view it on GitHub https://github.com/ShawnDEvans/smbmap/issues/48#issuecomment-1555453097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6SKWBP73B7WRGKJPG6VV3XHA3QTANCNFSM4MKHTVYA . You are receiving this because you were mentioned.Message ID: @.***>
Another possibility would be adding me as a maintainer of this repo, and I can set up the action.
@ShawnDEvans, it would help people and maintainers if you could package
smbmap
in a standard Python package that could be available on pypi.org.Take a look at my simple packages, like
nmaptocsv
, it's quite easy :)