:+1: nice work. A few notes after checking out the code:
Nice to see you successfully used OAuth login. OAuth is widely used and it's important to understand OAuth v1 and v2 properly.
Good to see you were able to format the timestamp cleanly.
Nice to see you used the SwipeRefreshLayout for easy timeline refreshes.
Good to see you added the new tweet directly to the home timeline after it was successfully posted to Twitter.
Nice touch with the character count being displayed while the user composes a tweet.
Good to see you used RxJava. Use of RxJava for any type of pub/sub such as field changes, API calls, etc. is considered good practice.
Good to see you used DialogFragment. Fragment is an important component and its use is good practice.
Consider using GSON to conveniently serialize and deserialize API responses into objects.
Consider adding local persistence of tweets by using DBFlow in the Tweet and User. See the persistence guide and this other guide for more details.
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
:+1: nice work. A few notes after checking out the code:
Tweet
andUser
. See the persistence guide and this other guide for more details.Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.