Closed usr3 closed 2 years ago
Thank you. I will factor out cached_property.
Sent from my iPhone
On Dec 17, 2021, at 3:00 AM, usr3 @.***> wrote:
I'm tried out the upcoming v2 branch on python 3.7 and it looks like cached_property was introduced in python 3.8. This breaks the minimum required version of Python 3.6+.
— Reply to this email directly, view it on GitHubhttps://github.com/ShayHill/docx2python/issues/25, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADAKIE7UYACHVKXLA4KMABTURL34PANCNFSM5KIKFQPQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>
factored out functools.cached_property to maintain 3.6 and 3.7 support.
@ShayHill sent a PR #27 for the sum() issue mentioned above.
I'm trying out the upcoming v2 branch on python 3.7 and it looks like cached_property was introduced in python 3.8. This breaks the minimum required version of Python 3.6+ as specified in README.
Edit: Similar compatibility issue with
sum()
in https://github.com/ShayHill/docx2python/blob/46effc36cd4bdc9186c03f6a77de1840cfeb9527/docx2python/docx_text.py#L90start
parameter as a keyword argument is compatible with Python 3.8+.