Shayokh144 / SurveyApp

0 stars 0 forks source link

[Bug] [UI] The Survey List screen doesn't match with design #8

Closed minhnimble closed 2 years ago

minhnimble commented 2 years ago

Why

The application needs to show the survey list screen after loading all the data with a valid logged in session like design. Currently there are a few problems with the survey list screen:

Acceptance Criteria

Actual:

Shayokh144 commented 2 years ago

New commit given : https://github.com/Shayokh144/SurveyApp/commit/cfb88840ff5f557d34b7752dcb8fb2c58f8c7fc3 Fixed problem List:

minhnimble commented 2 years ago

Thank you for your quick responses! I noticed most of the issues listed are fixed, nice work 👍. At the same time, regarding one of your reply, I would like to comment as follow:

page indicator is shown

→ Unfortunately, right now the left position of the page indicator is too close to the leading side of the screen unlike design. On top of that, tapping on a specific page index of the page control will only update the current indicator highlight, not the corresponding survey displaying content. Please help investigate and fix those issues as well 🙏

minhnimble commented 2 years ago

After checking your latest code changes from the merge, there are still a small issue that I would like to know more on your opinion:

https://user-images.githubusercontent.com/70877098/160049118-05c66ad6-f5df-4278-a0c6-da2f59b5553c.mp4

Shayokh144 commented 2 years ago

I have added code in willDisplayCell delegate of collectionVew to improve this issue .