search

Shazwazza / ClientDependency

DEPRECATED. A library for managing CSS & JavaScript dependencies and optimization in ASP.Net
139 stars 65 forks source link

Breaks when upgrading to dotless V1.6.4 #143

Closed dinc5150 closed 4 years ago

dinc5150 commented 6 years ago

Hey @Shazwazza ,

Sorry, I'm not sure if this is an issue with CD or Dotless.

I just upgraded the dotless nuget package to 1.6.4 on an Umbraco site. Works great in debug, until debug is turned off and the bundling kick in.

DependencyHandler.axd returns a status of 200 but no data in the response.

Any Ideas?

Shazwazza commented 6 years ago

Prob an issue with a change in Dotless, i'll have to investigate at some stage, do you have exact steps to replicate?

dinc5150 commented 6 years ago

Thanks @Shazwazza , It was as simple as updating dotless via nuget to 1.6.4. and then all my styles disapeared. I just tried a doing the same in a separate project with the same results.

I made a fork of ClientDependency and upgraded dotless. It wouldn't let me upgrade dotless until I upped the .net framework to 4.6.1. Once I compiled client dependency with .net 4.6.1+ it worked fine. So looks like you'll have to upgrade to .net 4.6.1 if you want to support it.

I've added a pull request if you want to use it. I've left dotless at V4.5 in the pull request all though it will support the latest version.

Hope it helps!

Shazwazza commented 4 years ago

Closing this, see comment https://github.com/Shazwazza/ClientDependency/pull/144#issuecomment-582154542