search

Shazwazza / ClientDependency

DEPRECATED. A library for managing CSS & JavaScript dependencies and optimization in ASP.Net
139 stars 65 forks source link

Folders with forcedproviders.. #119 #167

Closed mistyn8 closed 5 years ago

mistyn8 commented 5 years ago

re: #119 Just returning to the implementation of requiresJS(CSS)Folder and forceproviders (quite a lot later), and noticed that the nuget version of ClientDependency.MVC/MVC5 are prior to the enhancement, so umbraco8 doesn't get the folder forceprovider. Whilst I've cloned the repo and generated my own ClientDependency.Core.Mvc.dll (still v1.8.0) to include these, would I be correct in thinking automagic updates on umbracocloud would replace this with the earlier version?

Shazwazza commented 5 years ago

Yikes - that's 100% on me, looks like i didn't actually ship the CDF MVC package update, just the base package version, you can see here https://www.nuget.org/packages/ClientDependency-mvc5 ... there's only a single version of that one.

I'll ship now! Prob should ship 1.9.8 too since i think that's ready, i'll check.

Shazwazza commented 5 years ago

OK, should be there in a sec: https://www.nuget.org/packages/ClientDependency-Mvc5/1.9.3

Shazwazza commented 5 years ago

I'll update the nuspec for umbraco to use this version, but that won't be till 8.1.x or 71.5.x

mistyn8 commented 5 years ago

You are a star!

mistyn8 commented 5 years ago

Hi @Shazwazza just a friendly nudge, as just had another failed umbraco cloud update (post update checks fail the homepage render test as CDF regresses to core 1.97/mvc5 1.80)

I'm guesssing down to nuget dependency being the older versions? https://www.nuget.org/packages/UmbracoCms.Web/

cheers

Shazwazza commented 5 years ago

The umbraco nuspec was updated a couple months ago, see commit https://github.com/umbraco/Umbraco-CMS/commit/a9805e2b5ac7e7a46df4cfb67509e6478c52a3fb

I'm unsure if you are running v7 or v8 on cloud. Unfortunatley the v7 requirements were not bumped but I've just committed this one now https://github.com/umbraco/Umbraco-CMS/commit/b0e2f2d5113d36049a32c9a9be2523f9964b88a4

I'll ask the cloud team about upgrades to see if for some reason it doesn't respect the nuget requirements.

mistyn8 commented 5 years ago

I'm on the cloud 8.1 branch.  Looks like the dependency update was on 8.2. So hopefully when I update all will be hunky dory. ;-) Thanks!