search

ShazzAmin / Boole

A full-featured front end for George with various qualify-of-life features and workflow improvements
https://boole.shazz.me
MIT License
17 stars 11 forks source link

Add deploy action #42

Closed ShazzAmin closed 4 years ago

ShazzAmin commented 4 years ago

Resolves #29

derekyin commented 4 years ago

This builds in github actions and then copies completed build over right? Could there be any implications of this? i.e are there any cases where your server fails to execute the builds? just a though

ShazzAmin commented 4 years ago

This builds in github actions and then copies completed build over right? Could there be any implications of this? i.e are there any cases where your server fails to execute the builds? just a though

Yeah, the built files just need to be copied onto the server. The only failure I can foresee is the copy failing (due to network connectivity issue, server misconfiguration, etc.) but as long as it isn't a partial failure, everything should be fine (server will continue to serve old version). And if it does fail cause of some flake, we can manually trigger this action to attempt the deploy again.