SheCodeAfrica-Nairobi / SheCodeAfrica-Nairobi-Website

The new open source website for SheCodeNairobi website πŸ₯³
18 stars 25 forks source link

Dark mode for SheCodeAfrica-Nairobi-Website #30

Closed zidanegimiga closed 2 years ago

zidanegimiga commented 2 years ago

Hello! I'm suggesting that we add a dark mode for the website. Here's a modification I made using Figma. I'm requesting editing access if you like this. Link to prototype

she-code-dark-mode-conribution (1)

image

katungi commented 2 years ago

This is a really great initiative. Love it!! @M-Tee, can you check this out??

M-Tee commented 2 years ago

This is pretty cool. Love it.

M-Tee commented 2 years ago

@zidanegimiga I can't find your email on Github. Could you share it

zidanegimiga commented 2 years ago

@zidanegimiga I can't find your email on Github. Could you share it

Sorry about that, it's zidanegimigatemp@gmail.com

M-Tee commented 2 years ago

@zidanegimiga I've sent an edit invite to the Figma file you can copy and paste dark mode.

bettttttttttt commented 2 years ago

@katungi The site but done in Angular https://ng-sca-nairobi.netlify.app

Dark mode for the site matches device theme for now i.e. if your device is set as light theme, the site will be light and vice versa

katungi commented 2 years ago

Hey @bettttttttttt, I love what you did with Angular, if only our site was done in angular. Regardless, we could definitely do the same. This is issue is up for grabs. The idea is to have a toggle button that allows one to choose either dark or light mode, but by default it goes with the user's device theme.

bettttttttttt commented 2 years ago

@katungi I'm just doing it with Angular for fun. Anyway, I've added a skeleton loader on the events page, and the search input on the same page has a dynamic placeholder which I think is cool!

katungi commented 2 years ago

Wait, you did all those in angular still??

bettttttttttt commented 2 years ago

@katungi Yes, everything I'm doing is in Angular I'll share the repo by the end of the day

katungi commented 2 years ago

Cool, I will make sure to give you a shoutout for your amazing work @bettttttttttt πŸ‘πŸΏπŸ‘πŸΏ

katungi commented 2 years ago

I will close this for now and re-create a new issue for this so it can be worked on by someone else.