Closed katungi closed 1 year ago
hey @katungi i would like to work on this issue
Nevermind @katungi
Hey @fosa-ij , still interested in working on the issue??
Hey @katungi Gimme more insight on the bug
Hey @DreMukare , So on the events component, the images look bad. Ideally, they should fit the image component as per the design. So the task will be to make those images from the events data play well within the images.
Also, if you are feeling energetic and want to explore, you can try refactoring from the native img
tag to using Next's Image tag.
Can you handle this?
Yes i can :)
Hey @DreMukare , any update on this issue?
@katungi I'd like to continue with this
Hey @johnGachihi , yeah sure thing - go on and work on it.
@M-Tee, @katungi Eventbright uses landscape images but the event card design is for square images. The options I see for dealing with this mismatch are stretching and cutting the images to fit the square cards (which is how it is now) or rendering the images in landscape and filling the remaining space in the square cards like below.
What do you think? Should we go with one of these?
Hey @johnGachihi - I really like the last one. It's simple and concise!
@katungi I've tried playing around with the last option but it's leaving a lot of empty space which doesn't look good, especially on tablet-size screens. @M-Tee your opinion would really be appreciated.
Hey @johnGachihi , could you send a screenshot?
These are both on screen width 820px. The problem is mainly on the large event card
With the original layout
With a different layout meant to reduce the size of the large event card
:see_no_evil: I just noticed that the Eventbrite API also returns a url for the original uncropped event image. And the images are big enough to not get pixelated. I'll send a PR soon.
The dynamic images are scaling wrongly on the events component, This is a small issue that's a good first issue 👏🏿