SheCodeAfrica-Nairobi / SheCodeAfrica-Nairobi-Website

The new open source website for SheCodeNairobi website 🥳
18 stars 25 forks source link

Add Typings to the event response object for best typescript practices. #41

Closed EspiraMarvin closed 2 years ago

EspiraMarvin commented 2 years ago

The event from the events endpoint response has type any. Intending to add typings to the event response object for best typescript practices, and also help in response intelligent code autocompletion

katungi commented 2 years ago

Hey @EspiraMarvin , thanks for catching that, actually, I noticed lots of ambiguous type annotations in the project. Mind making sure everything looks good type-wise?

EspiraMarvin commented 2 years ago

@katungi Don't mind, also would use interfaces instead of types, since interfaces can be extended

katungi commented 2 years ago

Thanks for fixing this @EspiraMarvin!