search

Sheco / cdda-itembrowser

Cataclysm DDA: Item Browser
MIT License
25 stars 10 forks source link

Incorrect values for some objects (in Cooper) #4

Open slitherrr opened 9 years ago

slitherrr commented 9 years ago

Check out http://cdda-trunk.estilofusion.com/survivor_suit. Bash and Cut are given as 24 and 40, when they are listed as 12 and 18 in-game. I suppose the definitions for cut_resist and bash_resist in https://github.com/CleverRaven/Cataclysm-DDA/blob/9db58e12ccb961109000157273d5c4f70baeda20/src/item.cpp have changed, which seems like an annoying thing to have to keep up with.

In an unrelated note, I get why https://github.com/Sheco/cdda-itembrowser/pull/3 happened now: https://github.com/CleverRaven/Cataclysm-DDA/blob/9db58e12ccb961109000157273d5c4f70baeda20/src/item_factory.cpp#L656.

Sheco commented 9 years ago

Thank you for your report.

It seems the *_resist() methods have changed somewhat.

We would have to update /src/app/models/Item.php protection(), we might have to split that method into separate methods for each damage type.

Regarding #3... that's funny.