search

Sheco / cdda-itembrowser

Cataclysm DDA: Item Browser
MIT License
25 stars 10 forks source link

List of items made of material X only checks first material of the items #8

Closed Nandorianen closed 8 years ago

Nandorianen commented 8 years ago

Items that are made of multiple materials only show in the list of items made of the first one. For example, "headgear" is made of plastic and leather, shows up in "plastic" list, but not in "leather" list.

Sheco commented 8 years ago

If I recall correctly that was by design, when cutting items you only get the primary material (right?), so I thought it would be safe to assume you would only want to search by the primary material.

Do you believe it's useful to include items if their secondary material matches?

Nandorianen commented 8 years ago

It was the case, yes. It was changed some time ago, though, and at least in experimental builds you now get equal amounts of both materials. So cutting 10-volume pair of boots made of plastic and kevlar will net you up to 5 of both plastic chunks and kevlar plates.

Since there are relatively few item types you can safely cut up for rare materials like kevlar and nomex without worrying that they may be useful later, I'd say that being able to find all relevant items would be a useful thing.

Sheco commented 8 years ago

This patch fixes the material catalog, now we only need to fix the item view, so it shows the correct material yields when cutting.

Items with 10 volume of 1 material still yield 10 of that material, right?

Nandorianen commented 8 years ago

As far as I can tell, max salvage amount is volume / number of materials for each material, so yes.

Sheco commented 8 years ago

Ok, that's fixed now, when viewing an item, it shows it can be cut into its secondary material.

I checked the game's code and there's a salvage_multipler variable, which looks like is not used now, but I guess it will be used later, I'm not currently using it.