SheepGoMeh / VisibilityPlugin

Dalamud plugin to allow for quality of life changes for player and pet visibility.
GNU General Public License v3.0
25 stars 15 forks source link

[ISSUE/BUG] Visibility-Gpose Actor Duplication Issue #27

Closed Pewtershmitz closed 2 years ago

Pewtershmitz commented 2 years ago

Greetings! I'm here to report an issue with Visibility and Gpose.

Summary:

If I'm with someone in a party, they will be duplicated. I can manipulate the gpose actor, but the other actor (the "real" player one) isn't deleted when going into gpose, allowing them to move around freely while in gpose. If I'm not in a group, the dupe doesn't appear. If I am however, they can move around and do anything; they'll still show in the gpose. (See picture 1 and 2.)

Pic1 Pic2

Investigation:

So here are my findings after many hours of troubleshooting to find the issue. I managed to pin point it to Visibility, and here's my process:

Speculation on the problem:

Further examination of the issue (when I was trying to see what the issue was) lead me to understand that essentially the problem was that the "real" actor (Non controlled PC) was not being "deleted" when entering gpose. (Please refer to the screenshots below, Pics 3,4 and 5)

Pic3 As we can see, when entering gpose, the actor is duplicated. What I've managed to understand is that essentially the "real player" actor is not deleted / replaced by the "gpose actor". Of note here are the options: Controlled Character > PC and Non-controlled Character > PC

As you can see in Pic 4, deactivating Non controlled PCs deleted the "real" actor (the one that was able to move around, and left me with the gpose actor, which I could pose. Pic4

In contrast, deactivating the Controlled PC removed the gpose actor, but not the "real" actor. Pic5

Conclusions / TL;DR:

While I have no idea what might have been the issue, as I stated above, It has something to do with Visibility not deleting the "real" players' actors when transitioning into GPose, resulting in both the real and gpose actors remaining in scene. To my understanding, clearing the whitelist and removing the enable option does not fix the issue. Only way to remove the duplicated actor is by deactivating/uninstalling the plugin entirely. Special thanks to Xhiel for suggesting reporting it here.

I sincerely hope this helps on the coding side, as well as anyone else that has the same issue. Best of luck and thanks for the good work, -Pewtershmitz