search

SheepTester-forks / CurricularAnalytics.py

CurricularAnalytics.py is a Python port of CurricularAnalytics.jl, a toolbox for studying and analyzing academic program curricula.
https://pypi.org/project/curricularanalytics/
GNU Affero General Public License v3.0
2 stars 3 forks source link

Code quality #1

Open SheepTester opened 1 year ago

SheepTester commented 1 year ago

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/aadd3f6fe568db296c86d6ebb6583ae36e1acf27/src/DataTypes/DegreeRequirements.jl#L9-L44

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/aadd3f6fe568db296c86d6ebb6583ae36e1acf27/src/DataTypes/DegreeRequirements.jl#L52-L77

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/aadd3f6fe568db296c86d6ebb6583ae36e1acf27/src/CurricularAnalytics.jl#L753-L762

SheepTester commented 1 year ago

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/3cf07cedda11649578526ccb2253fd73e823c29c/src/CSVUtilities.jl#L120

SheepTester commented 1 year ago

Not from CA but I found this while trying to figure out how Pandas infers types

https://github.com/pandas-dev/pandas/blob/d3bc3722aeccb03841cda617c17f042736b04bb3/pandas/io/parsers/c_parser_wrapper.py#L314

SheepTester commented 1 year ago

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/26ae83a9594b93fb2448f69e2ef882462c8de6de/src/CSVUtilities.jl#L194-L195

SheepTester commented 1 year ago

I do not think this code has been tested

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/26ae83a9594b93fb2448f69e2ef882462c8de6de/src/CSVUtilities.jl#L237-L238

SheepTester commented 1 year ago

https://github.com/SheepTester-forks/CurricularAnalytics.py/blob/26ae83a9594b93fb2448f69e2ef882462c8de6de/src/DataHandler.py#L303-L304

typo here