fix: getTimeZoneOffset needs to return a double instead of integer at v8

SheetJS / sheetjs

📗 SheetJS Spreadsheet Data Toolkit -- New home https://git.sheetjs.com/SheetJS/sheetjs

https://sheetjs.com/

Apache License 2.0

34.78k stars 7.99k forks source link

fix: getTimeZoneOffset needs to return a double instead of integer at v8 #2811

Open queguangwei opened 1 year ago

queguangwei commented 1 year ago

I found that the return time of the datenum method in Chrome browser is incorrect, consider customizing a getTimeZoneOffset function to fix Date.prototype.getTimezoneOffset() return error value

SheetJSDev commented 1 year ago

This issue was reported to V8 years ago https://bugs.chromium.org/p/v8/issues/detail?id=7863 but it seems like there has been no movement (and unfortunately a large number of issues are reported here).

queguangwei commented 1 year ago

I see, since v8 does not fix the problem, do we consider fixing the problem in the code.

koticmit commented 3 months ago

@SheetJSDev, Would be nice if we get new release with latest commits. Waiting for once of the security fix ReDos in your package to be fixed. They say below that it is fixed in master branch but not yet released. Many thanks if you can do it.