search

SheetJS / sheetjs

📗 SheetJS Spreadsheet Data Toolkit -- New home https://git.sheetjs.com/SheetJS/sheetjs
https://sheetjs.com/
Apache License 2.0
35.2k stars 7.99k forks source link

Fix for Issue 2752 where blankrows:true skips first blank line #2815

Open abhiram11 opened 1 year ago

abhiram11 commented 1 year ago

This PR tries to solve #2752 which is also mentioned in PR #2776 but it did not pass all tests of a PR as set by SheetJS.

This PR consists of two commits:

  1. Same code as mentioned in https://github.com/SheetJS/sheetjs/issues/2752#issuecomment-1203205189
  2. After running yarn lint, two other files were also updated, namely xlsx.js and xlsx.flow.js, which are also committed in this PR. These were missing in the code changes of PR #2776 .

Let's hope this time all tests cases are passed!

abhiram11 commented 1 year ago

There seems to be plenty of test cases failing, please let me know if there is something specific that I'm doing wrong or is there some other reason itself!