search

SheffeyG / CheatDeck

Launch games with cheat or trainer and manage launch options for steamdeck
GNU General Public License v3.0
46 stars 5 forks source link

Overwriting other launch options #11

Closed markspo closed 7 months ago

markspo commented 8 months ago

I have a few GOG games that I installed, and have them all share a prefix folder using

STEAM_COMPAT_DATA_PATH="/home/deck/.steam/steam/steamapps/compatdata/experimental" STEAM_COMPAT_MOUNTS=/run/media/mmcblk0p1 WINE_LARGE_ADDRESS_AWARE=0 PROTON_FORCE_LARGE_ADDRESS_AWARE=0 %command%

When setting CheatDeck, it blows out the current option, and replaces it, thus creating a new prefix folder. I've attempted to append the CheatDeck options with the current options, but it won't load the trainer. I've attempted to put the trainer in the prefix directory, and in my /home/deck/Downloads, still nothing.

Is there a way to fix this?

SheffeyG commented 8 months ago

@markspo The overwrite problem should be fixed in the new pre release v0.2.0, you can install and test it from url

eXhumer commented 7 months ago

@SheffeyG Can this be reopened due to issue with the current implementation? I have a WINEDLLOVERRIDES="dinput8=n,b" in some of my games like RE4 (to add REFramework) and other kinds of mod support. CheatDeck replaces the entry with WINEDLLOVERRIDES="dinput8 and breaks running the application until I go and manually fix the launch options back.

EDIT: Issue seems to be with the following implementation.

https://github.com/SheffeyG/CheatDeck/blob/3f36f0a35163ad0f38ee92ce59c9b1d704298459/src/utils/options.tsx#L8

It needs to be replaced with const [key, value] = pair.split(/=(.*)/s); or something equivalent which only splits on the first occurrenc of =. If this can be considered a valid fix, I can create a PR with the change needed.

SheffeyG commented 7 months ago

@eXhumer You are right, a fix pr is appreciated