SheffeyG / CheatDeck

Launch games with cheat or trainer and manage launch options for steamdeck
GNU General Public License v3.0
46 stars 5 forks source link

Issues with Custom Options #16

Open eXhumer opened 7 months ago

eXhumer commented 7 months ago

I noticed that a way to add custom launch options via CheatDeck is being added, but I found several bugs with the current implementation where modifying the option with a new key or value has few issues with it. If you modify only the value of an existing custom option, the new value seems to be never applied even when you save. If you modify the key of the custom option, it will not remove the old key and will instead add a new key=value pair alongside the old key=value pair.

Additionally the value field doesn't appear to be touch interactable and I have to use the DPad to access the value field.

eXhumer commented 7 months ago

Also, deleting the custom option doesn't appear to remove the option from launch options. I have to manually go to launch options and remove it.

SheffeyG commented 7 months ago

The modified options with a new field would be a "new" options, so the changes from custom list (local storage) will never affect the launcher options, unless you explicitly toggle and save it, because some other apps like EmuDeck and Heroic launcher make their own launch options. The new value seems to be never applied is a bug, I didn't check the value change, glad you pointed it out, it should be fixed now. A modified value will be show as a disabled option. I am not sure if there are any better ways to do it or suggestions, so I will keep this issue open

SheffeyG commented 7 months ago

The custom options items are stored at local storage, they are not for only the current game, you can quick access them in any other games, so the change of the custom items will never affect the current games launch options