search

Sheffield-iGEM / syn-zeug

A modern toolbox for synthetic biology
https://sheffield-igem.github.io/syn-zeug/
GNU Affero General Public License v3.0
6 stars 3 forks source link

gc_content is complete! #44

Closed adam-spencer closed 2 years ago

adam-spencer commented 2 years ago

I believe this function is complete, along with tests, a new error type and benchmarking. Please let me know if there's anything missing. xoxo

TheLostLambda commented 2 years ago

Heya! This is looking pretty good! I'm just poking around with some benchmarks still, but I think this should be something we can merge soon!

Feel free to have a stab at some of the other tools if I'm holding you back!

Thanks a ton!

TheLostLambda commented 2 years ago

Hey @adam-spencer! Just made some style tweaks, added a few tests, and changed some benchmark internals, but I think this is ready to merge! The approach you used for IUPAC support was the fastest I could find by far, but I added a little shortcut for the Alphabet::Base sequences that nearly doubled the speed for me.

Thanks for all of the hard work you put into this and let me know if you want to take a swing at another tool with all of this experience you have now!

adam-spencer commented 2 years ago

Thanks a bunch, I've really enjoyed learning about Rust. I'll have a go at another tool, though no promises about if/when it'll be completed as I'm a little preoccupied preparing for my dissertation.

I'll write a couple of comments on the issues I'm assigned to if I have any questions. I know there's a lot to do at this stage of iGem so no worries if it takes you a while to respond.