search

SheffieldML / GPyOpt

Gaussian Process Optimization using GPy
BSD 3-Clause "New" or "Revised" License
928 stars 261 forks source link

The parameter num_cores doesn't work. #351

Open LilyEvansHogwarts opened 3 years ago

LilyEvansHogwarts commented 3 years ago

I read methods/bayesian_optimization.py and find the objective is defined as self.objective = SingleObjective(self.f, self.batch_size, self.funct_name). And I believe it should be changed into self.objective = SingleObjective(self.f, self.num_cores, self.funct_name). Otherwise, the num_cores parameter would be useless.

LilyEvansHogwarts commented 3 years ago

The original code in methods/bayesian_optimization.py self.num_cores = num_cores if f is not None: self.f = self._sign(f) self.objective = SingleObjective(self.f, self.batch_size,self.objective_name) else: self.f = None self.objective = None I believe the code should be changed into: self.num_cores = num_cores if f is not None: self.f = self._sign(f) self.objective = SingleObjective(self.f, self.num_cores,self.objective_name) else: self.f = None self.objective = None

ragak commented 3 years ago

Thank you for posting this! I wasn't able to use multiple cores until I made this switch.