search

SheffieldML / deepGPy

Deep GPs with GPy
BSD 3-Clause "New" or "Revised" License
31 stars 10 forks source link

Using deepGPy choleskies? #4

Closed mathDR closed 9 years ago

mathDR commented 9 years ago

In coldeep.py there is a line:

from GPy.util.choleskies import indexes_to_fix_for_low_rank

But within the package there is a choleskies.py file containing the same function. Do you mean to use the GPy version?

jameshensman commented 9 years ago

Hi Dan,

Yeah, there's some functionality that was written for DeepGPy that I later moved (copied) into GPy because it was more generally useful, so sometimes there will be a clash.

Cleaning up DeepGPy is on the agenda!

James.

On 22 September 2015 at 19:23, Dan Marthaler notifications@github.com wrote:

In coldeep.py there is a line:

from GPy.util.choleskies import indexes_to_fix_for_low_rank

But within the package there is a choleskies.py file containing the same function. Do you mean to use the GPy version?

— Reply to this email directly or view it on GitHub https://github.com/SheffieldML/deepGPy/issues/4.

mathDR commented 9 years ago

Sounds good James. Does this still imply that the devel branch of GPy is the one to link to? Or will you be linking to the master branch after the cleanup?

And I think we can close this issue.

Dan

jameshensman commented 9 years ago

Hi Dan,

I think everything should work with GPy 0.8 now.

James.

On 23 September 2015 at 16:02, Dan Marthaler notifications@github.com wrote:

Sounds good James. Does this still imply that the devel branch of GPy is the one to link to? Or will you be linking to the master branch after the cleanup?

And I think we can close this issue.

Dan

— Reply to this email directly or view it on GitHub https://github.com/SheffieldML/deepGPy/issues/4#issuecomment-142630080.