search

SheffieldSolar / PV_Live-API

A Python implementation of the PV_Live web API.
16 stars 4 forks source link

run blacks #9

Closed peterdudfield closed 1 year ago

peterdudfield commented 2 years ago

run blacks line length 100 on main file

I know blacks isnt perfect, but there is somehting nice about doing formatting automatically

JamieTaylor-TUOS commented 2 years ago

Hmm, not a huge fan of the way black formats things - I tend to use pylint to test conformity with PEP8 and then fix manually.

In particular, Black appears to have introduced some non-PEP8 compliant formatting on lines 345, 409 and 412 (see flake8 output in checks). In these cases, I prefer the pre-blackened code.

That said, I can see the value of some changes in terms of minimising diff sizes - is there some compromise by tweaking black settings, or is that contrary to the black mission statement?

I could be convinced if there's a strong argument?

[On a side note - tests for this code are failing due to the API slowdown we've been discussing - I'll see if there's anything I can do]