search

Sheherezadhe / awair-uploader

GNU General Public License v3.0
121 stars 57 forks source link

Docker Image #2

Open pete-leese opened 2 years ago

pete-leese commented 2 years ago

Would be good to build this into a docker image.

mph174 commented 2 years ago

That would be sweet!

Sheherezadhe commented 2 years ago

I know I know!

But look, give me time to focus on the part with the endpoint and the general functionality. From my perspective it is a priority to make it work and test it first. Then next step will be executables, images and other things. I am all aware that user side implementations matter, but sorry it is at this moment not my priority. Later I hope that also others assist, it is getting a bit much especially with testing the endpoint currently.

pete-leese commented 2 years ago

I am happy to contribute to the project once first milestones have been reached.

Sheherezadhe commented 2 years ago

And I am happy if others take over and make things better. Tests are ongoing, I can not update the endpoint yet today, it is still being tested and I need approval before releasing. We are trying our best to progress.

elmocito commented 2 years ago

Would also love to see the docker image 😍 (NAS is running anyway 🙈) Thanks for all of your work!

psavva commented 2 years ago

I can try contribute this tomorrow :)

shackrock commented 2 years ago

+1!

psavva commented 2 years ago

The application is built and run using electron-forge. Electron is designed to run an application in a native operating system, and is treated like a normal native application. ie: It's not running as a web server, and thus, when building, you're actually just making the binaries for the target systems. hence, you have the .exe file, instead of a standalone web application.

@Sheherezadhe Perhaps you know of any way to run the electron-forge application and serve it on a web server such as nginx, rather than than as an electron-forge app?

elmocito commented 2 years ago

Seems there is no proper way: Link

psavva commented 2 years ago

I had recently faced the same dilemma, and my only solution was to re-write the application with electron. ie: I needed to run the application in docker, but it was originally built with electron. I fully stripped out electron to make it work....

I'm not sure if there is any options with electron-forge?

psavva commented 2 years ago

Dear @Sheherezadhe

I have done my best to strip out electron-forge here: https://github.com/psavva/awair-uploader/tree/dockerbuild

I'm currently facing an infinite loop on the keycloak redirect. If you run the application, you'll find the problem very quickly after the initial login to Planetwatch. You'll notice an endless redirect loop (due to keycloak), but i'm not sure where, and how... I've tried debugging this for a few hours with no prevailance, so I'm reaching out to the community here to have a look, submit a PR against it, and if everything works the way it's intended, we will be able to deploy in docker.

When things are running, then i'll provide the dockerfile, and docker-compose which will allow for quick and easy installation.

Best Regards Panayiotis Savva