Shelagh-Lewins / twisted-threads

Twisted Threads - a Meteor app for tablet weaving
MIT License
1 stars 1 forks source link

Max rows in Auto sequence can be bypassed when importing json #26

Open CableGuy67 opened 5 years ago

CableGuy67 commented 5 years ago

When importing a json file in Twisted Threads format the max turning rows can be bypassed by manually adding the "F" and "B" sequence to the json file to the auto_turn_sequence array. Once the number of turns exceed 48 (the hard limit for the ui) trying to view the band horizontally won't display anything but a list of the card numbers. Trying to see the print friendly page won't display the band either as it is shown as a horizontal left to right band. Oddly enough, the thumbnail on the patterns page (also horizontal left to right) will display correctly.

Some possibilities to consider. Keep the max 48 rows as the default but allow for the max to be adjusted somewhere deeper in the pattern UI in the same way that the "make public" is a click in so that increase requests could be dealt with on an as needed basis. I don't know what the overhead is for the rows but from what you have said it is in the way the database keeps the patterns? I do think 48 is too small overall. Somewhere around 60 or 80 is a more realistic baseline max imo.