search

ShelbyTV / Shelby-2.0-iOS

The code in this repoistory will eventually be presented to the end-user. The other repository, Shelby-GT-iOS contains all the code I've developed between April - August 2012, which will slowly be siphoned into this repository as we continue development on 2.0 and beyond.
1 stars 0 forks source link

First round of assigned iOS tasks #444

Closed iceberg901 closed 10 years ago

iceberg901 commented 10 years ago

@spinosa Here's all the tasks you assigned me in my first wave for iOS, now done. Please review, merge, and feel free to find me some more stuff in Trello. I'm trying to select some of the tasks for myself but sometimes it's hard to know if they're within my reach yet.

spinosa commented 10 years ago

i'm psyched to see these commits! let's review them IRL tomorrow (Wednesday)

in the mean time, i've mentioned you in a couple trello tasks that are in your range or just above and better for tackling independently

danSpinosa.com shelby.tv/spinosa learn about your world

On Tue, Feb 25, 2014 at 4:04 PM, iceberg901 notifications@github.comwrote:

@spinosa https://github.com/spinosa Here's all the tasks you assigned me in my first wave for iOS, now done. Please review, merge, and feel free to find me some more stuff in Trello. I'm trying to select some of the tasks for myself but sometimes it's hard to know if they're within my reach

yet.

You can merge this Pull Request by running

git pull https://github.com/ShelbyTV/Shelby-2.0-iOS ipad-Josh

Or view, comment on, or merge it at:

https://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444 Commit Summary

  • Capitalize Facebook and Twitter on Stream Card
  • Call anonymous users "Me", not "Video Lover"
  • Change copy over video player that appears right after user taps "Get Started"
  • In the UserFollowingViewController,filter out roll types greater than 16,since iOS doesn't know what to do with any of them

File Changes

  • M Shelby.tv/Shelby.tv/ShelbyUserFollowingViewController.mhttps://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444/files#diff-0(3)
  • M Shelby.tv/Shelby.tv/StreamBrowseCellForegroundView.mhttps://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444/files#diff-1(4)
  • M Shelby.tv/Shelby.tv/StreamUserEducationView.xibhttps://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444/files#diff-2(44)
  • M Shelby.tv/Shelby.tv/User+Helper.mhttps://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444/files#diff-3(2)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/ShelbyTV/Shelby-2.0-iOS/pull/444 .

iceberg901 commented 10 years ago

Adding more commits for additional tasks as I go