search

ShelbyTV / Shelby-iOS-Proto

iPhone/iPad native app for Shelby
1 stars 0 forks source link

iPhone - ShareView too wide. #70

Closed DavidYKay closed 13 years ago

DavidYKay commented 13 years ago

We'll need to find a nicer design for the STVShareView on iPhone. Haven't spent much time on this yet.

DavidYKay commented 13 years ago

Looks like we're going to use a UITableView-based approach rather than the standard Shelby UI for this piece. This approach will be more similar to the implementation in Apple's Mail app and maximizes use of the tiny screen (when keyboard is shown).

Currently planning on using Three20's TTMessageController to fit the bill.

markerrj commented 13 years ago

I'd prefer it if we didn't link in the Three20 framework... Or were you just planning on using part of it?

DavidYKay commented 13 years ago

So it looks like in the olden days that I'm familiar with, you'd have to link in the whole thing.

However, these days, it looks like you can link in part of it.

Let me see how light we can make it. Are you more worried about the size of the resulting binary, or the logistics of maintaining yet another dependency?

On Sun, Oct 9, 2011 at 12:49 AM, Mark Johnson reply@reply.github.com wrote:

I'd prefer it if we didn't link in the Three20 framework... Or were you just planning on using part of it?

Reply to this email directly or view it on GitHub: https://github.com/ShelbyTV/Shelby-iOS-Proto/issues/70#issuecomment-2335271

David Young-Chan Kay http://gravatar.com/DavidYKay DavidYKay@gmail.com

markerrj commented 13 years ago

I'm worried about both, but more about logistics of another dependency.

And I think Three20 is fairly heavyweight? Unless I'm mistaken.

I guess I was hoping that we could just design another, smaller share dialog for the iPhone...

DavidYKay commented 13 years ago

Well, I spoke with Reece and Dan and they were very interested in replicating the Mail.app UI, at least for email sharing.

If we don't go with Three20, the thing that I'm most worried about is replicating behavior of the Mail app's add/remove contacts UI. The way that they transform the text into the blue bubbles and back seems to be difficult to replicate in a one-off manner.

Three20 has that along with a nice mail composer. I imagine a lot of engineering time went into it.

Depending on the open source license and difficulty of the code, we may be able to perform surgery and just remove those bits that are most important, but we'd be weighing that against linking against Three20.

On Mon, Oct 10, 2011 at 2:52 PM, Mark Johnson reply@reply.github.com wrote:

I'm worried about both, but more about logistics of another dependency.

And I think Three20 is fairly heavyweight? Unless I'm mistaken.

I guess I was hoping that we could just design another, smaller share dialog for the iPhone...

Reply to this email directly or view it on GitHub: https://github.com/ShelbyTV/Shelby-iOS-Proto/issues/70#issuecomment-2350837

David Young-Chan Kay http://gravatar.com/DavidYKay DavidYKay@gmail.com

markerrj commented 13 years ago

hmm, ok. well, in that case, i guess go for it.

if we have problems with the Three20 framework later on, will just have to deal with them.

DavidYKay commented 13 years ago

Thanks. Let me see what I can do to minimize the footprint.

On Mon, Oct 10, 2011 at 3:07 PM, Mark Johnson reply@reply.github.com wrote:

hmm, ok. well, in that case, i guess go for it.

if we have problems with the Three20 framework later on, will just have to deal with them.

Reply to this email directly or view it on GitHub: https://github.com/ShelbyTV/Shelby-iOS-Proto/issues/70#issuecomment-2351013

David Young-Chan Kay http://gravatar.com/DavidYKay DavidYKay@gmail.com

DavidYKay commented 13 years ago

Believe this is resolved by @markerrj's fixes. Closing.