search

ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

Update frame view to only re-render conversation on conversation change #141

Open iceberg901 opened 12 years ago

iceberg901 commented 12 years ago

Right now the frame view re-renders the entire frame when the conversation changes. All that is really necessary is to re-render the conversation - the '.video-author' tag and the subsequent messages inside the <ul>. Added benefit of fixing this is that it will probably enable additional refactoring and code reuse between the frame view and the comment overlay view, both of which do MessageView re-rendering on change of the active frame model's conversation.

matyus commented 12 years ago

@iceberg901 is this relevant since we've moved to the full guide view and changed the "comment overlay" to a "context overlay" ?

iceberg901 commented 12 years ago

@matyus Potential refactoring advantages are now gone since the duplicate code has already moved into frame_conversation.view.js However this code still uses the same old approach of re-rendering the entire view on conversation change. There's probably a performance benefit to be gained from only re-rendering the actual messages at this point, but probably less so than in the old frame view (which had much more HTML in it) and whether or not said benefit will be important/noticeable is unclear to me.