search

ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

load more stops working after deleting a frame #364

Closed spinosa closed 12 years ago

spinosa commented 12 years ago

to reproduce:

  1. Go into your queue
  2. Delete any frame
  3. Scroll down

You'll notice that it doesn't auto-load more like it should. And if you manually click load more it doesn't work

Please look into this @mkrecny

iceberg901 commented 12 years ago

I'm not positive, but I think that infinite scrolling is based on detecting scrolling to the combined height of all the elements in the list view. Therefore, both StreamPlay and deleting frames cause problems with this, since the collapsing and expanding of frames and the removal of frames changes the total height, but infinite scrolling is not informed of the new height. I'm saying all this without looking at the code so it could be nonsense, but it feels right.

A more flexible approach would be to load more when the "Load More" button becomes visible. Then it wouldn't matter if the height of the elements inside the scroll area changed. jquery Appear is good for this kind of stuff:

http://code.google.com/p/jquery-appear/

iceberg901 commented 12 years ago

Fixed as part of other work on Streamplay and frame removal issues