iceberg901
commented
12 years ago Another issue that I've fixed in the College Humor player, which should be checked for in all the other players, worked like this:
- render() gets called on the player - inside, the player sets its styles to be visible then sets is playerState.visible to true
- playVideo gets called by the player's parent, kicking off an asynchronous attempt to build the player and/or play the video
- at some intervening moment, some client action causes the player view to be left (arrow key pressed, new video clicked. etc.), and within its leave method it sets the player styles to not be visible
- at some later time, with the player now hidden, a callback returns to the player signaling that the asynchronous attempt to build the player/play the video has succeeded, and within the callback the player updates its playerState.visible to true even though it is hidden
So the general issue is updating state in a callback to reflect conditions at the time the asynchronous method was called, when those conditions may have changed in the interim.
ckurdziel
We've found that some of the players sometimes keep playing when they are hidden. I am implementing fixes for Vimeo and Collegehumor. However, the issue is a fairly generic one, and we should test all of the other players for it individually and fix them if necessary. This is only an issue for players that don't get completely torn down when leave() is called on them.
The general issue is when you leave a player view and try to pause the player when the video is in a state that doesn't accept pausing. A common case here is that the player is in the middle of an asynchronous process (or buffering) that will ultimately result in it playing, but it isn't playing yet. You can't pause yet, so when you try to pause the player on leave nothing happens. Then you hide the player and later that asynchronous process returns and starts playing the hidden player.
The fix I'm using should be appropriate for all of the players, but the implementation is different in each case. The basic idea is to keep track of whether the player is the active player (a private boolean member _isActivePlayer works nicely) and then in any callback that signals that the player has started playing, if the player is not the active player, pause immediately.