search

ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

player controls not showing on Hulu vids #565

Closed reecepacheco closed 12 years ago

reecepacheco commented 12 years ago

no player controls showing up on this video http://shl.by/f0W

should be Hulu player controls

space bar does pause the video

iceberg901 commented 12 years ago

Can't do this one until I get back. Hulu doesn't work in CZ. I'll pick it back up if it's still outstanding when I return.

iceberg901 commented 12 years ago

@reecepacheco Henry says you're inquiring with Hulu if we can put our controls on top now. I'm going to assign this item to you until you get confirmation on that.

reecepacheco commented 12 years ago

i talked to Hulu yesterday and @hsztul is now in touch with the right people. reassigned so he can plug Hulu, i mean... plug this hole... i mean....

hsztul commented 12 years ago

Hole Plugged!

Can not set height or width on #videoPlayerComponent, #adComponent DIVS.

see snl-shorts.shelby.tv in case you want to see it in action...

matyus commented 12 years ago

@hsztul, after thinking about it today, I realized that our initial thoughts on comma delineation:

:not(.x,.y)

is not exactly robust, and it ended up being somewhat magical that it worked in Chrome (that might be the only browser that it would work in).

The cross-browser-safe approach to compounding multiple :not() selectors. 

:not(.x):not(.y)

Not in the position to make commits right now but I'll fix it Monday if you don't get to it before then!

hsztul commented 12 years ago

cool, good to know! i probably won't get to it till monday either...

Henry :: shelby.tv

On Saturday, September 22, 2012 at 6:23 PM, Michael Matyus wrote:

@hsztul (https://github.com/hsztul), after thinking about it today, I realized that our initial thoughts on comma delineation: :not(.x,.y)
is not exactly robust, and it ended up being somewhat magical that it worked in Chrome (that might be the only browser that it would work in). The cross-browser-safe approach to compounding multiple :not() selectors.
:not(.x):not(.y)
Not in the position to make commits right now but I'll fix it Monday if you don't get to it before then!

— Reply to this email directly or view it on GitHub (https://github.com/ShelbyTV/shelby-gt-web/issues/565#issuecomment-8793425).

iceberg901 commented 12 years ago

Fixed for real with #616

Should point out that the invalid selector used here caused #616, #617 and various other video player bugs