Notification overlay doesn't reset its timeouts

ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />

shelby.tv

3 stars 0 forks source link

Notification overlay doesn't reset its timeouts #741

Closed iceberg901 closed 11 years ago

iceberg901 commented 11 years ago

Roll a video This brings up the "You successfully rolled" notification overlay, which should auto-hide after nine seconds Within less than nine seconds, try to roll another video, but blank out the comment field first The notification overlay will be replaced with one that says "Please enter a comment"

This overlay should stay up until the user dismisses it, but it will actually auto-hide after the original nine seconds have elapsed.

Each new notification overlay should reset any previously set auto-hide timeouts.

spinosa commented 11 years ago

@matyus did your recent notification updates also take care of this?

matyus commented 11 years ago

NOPE. I've been aware of the issue but haven't taken the time to address it.

The UX needs to be figured out:

How do alerts queue up? The main issue is that shelby.alert automatically dismisses while shelby.dialog waits for the user to choose an option...

Do they stack visually, so that you see more than one at a time, and have the ability to address each one individually?
Do they appear in order of "most recent" ?
Does the newest one just wipe out the older one?

spinosa commented 11 years ago

i've got a feeling our code would tell us the best fix is "newest one just wipe out the older one." That's what GMail does. It's good enuf for now as this is a bit of an edge case.

spinosa commented 11 years ago

fixed on staging