ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

TOU and Privacy links broken on landing page #749

Closed reecepacheco closed 11 years ago

reecepacheco commented 11 years ago

these two links are not redirecting properly from the homepage: http://shelby.tv/tou.html http://shelby.tv/privacy.html

spinosa commented 11 years ago

@iceberg901 these are both in public/ and used to be automatically served by nginx b/c they exist in public/. Seems the move to unicorn changed this.

What do you think of updating this directive

  location ~ ^/(assets|fonts|images|javascripts|stylesheets|system)/ {
    root /home/gt/web/current/public;
    gzip_static on;
    expires max;
    add_header Cache-Control public;
  }

by adding html to the location regex and then moving our public .html files into public/html in the repo?

iceberg901 commented 11 years ago

Turns out there's a much more concise nginx directive for doing this called try_files:

http://nginx.org/en/docs/http/ngx_http_core_module.html#try_files

I'll take care of it. Staging first :)

iceberg901 commented 11 years ago

Nevermind. Too much collateral fixing necessary to use the try_files directive as we've already overcomplicated/underthought our approach here. I'll keep going with the pattern we've been using and your idea will work nicely.

iceberg901 commented 11 years ago

Nginx config updated in chef repo. Chef scripts run on staging and production. Static html files moved to new folder and deployed.