Closed spinosa closed 11 years ago
@matyus not sure how you want to this to be restyled for a longer message... with shelby loaded in the browser, in a console execute:
shelby.alert("In order to provide a great experience we need you to re-authenticate with facebook. Don't worry, you'll be re-directed back to Shelby. Yay!", function(){ document.location.href = "http://google.com"; });
the current notification alert, shelby.alert(), does size appropriatly
@matyus let me know if you just want to knock this off or have ideas on how to proceed based off your styles.
@matyus never heard from you on this, is this something you can knock off?
I can handle this, excuse my negligence!
fix is going on staging this evening.
messages will be passed in an object. it is often the case that the buttons will need to be modified like so:
shelby.alert({
message: "In order to provide a great experience we need you to re-authenticate with facebook. Don't worry, you'll be re-directed back to Shelby. Yay!",
primary: {
title: 'Re-authenticate Facebook',
route: _fbAuth
},
secondary: {
title: 'No thanks'
}
},
function(){ document.location.href = _fbAuth; }
);
more details will be in the email, but the breakdown is that "primary" and "secondary" are the two buttons, they typically need "title". "route" is optional because it's usually going to close the alert itself.
fixed on staging
When Shelby needs to re-authenticate a user with Facebook (to update our fb permissions/token), we present a notification the next time they sign in.
The layout of this notification is such that 1) you cannot read it and 2) you cannot take the appropriate action / click link
@hsztul assigning this to you since you know how to reproduce the FB re-auth request, but have a feeling it's mostly layout work that @matyus could do/help with.
P1, in production, lower priority than fredwilson.tv launch