search

ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

.TV Bug: Clicking on a different frame before clicking play on the .TV popup plays the wrong video #796

Closed ckurdziel closed 11 years ago

ckurdziel commented 11 years ago

Steps to reproduce: 1) Go to Fred Wilson.TV 2) Open the Guide 3) Click on a video in the guide 4) Click the play button in the popup that is on the middle of the screen 5) Observe that the .TV plays the first video not the video you just clicked on.

Can reproduce this on any .TV.

iceberg901 commented 11 years ago

Should you be able to click on anything at all before you've clicked play on that popup? In other words, is the popup supposed to be modal? @hsztul @matyus?

If not, then there is one other problem too, which is that the invisible top of the wrapper that contains the popup prevents you from clicking on rolls in the top banner where it overlaps them.

spinosa commented 11 years ago

1) This is only reproducable when the video you change to is of the same player (ie. choosing a video from a different provider works as expected) -- this hints at a possible solution focused on the video player itself, not other logic 2) a modal popup would be annoying for any repeat visitor (ideally, clicking outside this popup should dismiss it)

setting to P2 until we know this is more than an uncommon edge case (if users do this a bunch after we launch fw.tv, this is P1)

iceberg901 commented 11 years ago

This applies to old .tv's which are no longer part of the app. I tested and verified that exactly this edge case works on new .tvs. Closing.