ShelbyTV / shelby-gt-web

the new shelby web front end for rolls <over />
shelby.tv
3 stars 0 forks source link

Mobile roll view crashes when a frame doesn't have a video #816

Closed iceberg901 closed 11 years ago

iceberg901 commented 11 years ago

One definite case is roll id 51120b36b415cc271a043678, where frame 51120b37b415cc271a043702 has no video. Encouragingly, the regular web app is already robust enough to handle this gracefully.

Example error report:

A ActionView::Template::Error occurred in mobile#roll:

undefined method []' for nil:NilClass app/views/mobile/roll.html.erb:7:inblock in _app_views_mobile_roll_html_erb__193357333496313473_25607980' ------------------------------- Request:

app/views/mobile/roll.html.erb:7:in block in _app_views_mobile_roll_html_erb__193357333496313473_25607980' app/views/mobile/roll.html.erb:6:ineach' app/views/mobile/roll.html.erb:6:in _app_views_mobile_roll_html_erb__193357333496313473_25607980' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/template.rb:145:inblock in render' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications.rb:125:in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/template.rb:143:inrender' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/template_renderer.rb:47:in block (2 levels) in render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/abstract_renderer.rb:38:inblock in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications.rb:123:in block in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications/instrumenter.rb:20:ininstrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications.rb:123:in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/abstract_renderer.rb:38:ininstrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/template_renderer.rb:46:in block in render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/template_renderer.rb:54:inrender_with_layout' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/template_renderer.rb:45:in render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/template_renderer.rb:18:inrender' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/renderer.rb:36:in render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_view/renderer/renderer.rb:17:inrender' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/rendering.rb:110:in _render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/streaming.rb:225:in_render_template' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/rendering.rb:103:in render_to_body' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/renderers.rb:28:inrender_to_body' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/compatibility.rb:50:in render_to_body' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/rendering.rb:88:inrender' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/rendering.rb:16:in render' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:40:inblock (2 levels) in render' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/core_ext/benchmark.rb:5:in block in ms' /home/gt/.rvm/rubies/ruby-1.9.3-p286/lib/ruby/1.9.1/benchmark.rb:295:inrealtime' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/core_ext/benchmark.rb:5:in ms' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:40:inblock in render' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:83:in cleanup_view_runtime' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:39:inrender' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/implicit_render.rb:10:in default_render' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/implicit_render.rb:5:insend_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/base.rb:167:in process_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/rendering.rb:10:inprocess_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/callbacks.rb:18:in block in process_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:426:inblock in _run3433251135050766330process_action1761227839986750326callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:215:in block in _conditional_callback_around_38' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/vanity-8090027f857b/lib/vanity/frameworks/rails.rb:104:invanity_context_filter' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:214:in _conditional_callback_around_38' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:414:in_run3433251135050766330process_action1761227839986750326callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:405:in __run_callback' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:385:in_run_process_action_callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:81:in run_callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/callbacks.rb:17:inprocess_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/rescue.rb:29:in process_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:30:inblock in process_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications.rb:123:in block in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications/instrumenter.rb:20:ininstrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/notifications.rb:123:in instrument' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/instrumentation.rb:29:inprocess_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/params_wrapper.rb:207:in process_action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/base.rb:121:inprocess' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/abstract_controller/rendering.rb:45:in process' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal.rb:203:indispatch' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal/rack_delegation.rb:14:in dispatch' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_controller/metal.rb:246:inblock in action' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/routing/route_set.rb:73:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/routing/route_set.rb:73:indispatch' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/routing/route_set.rb:36:in call' config/initializers/routing_invalid_chars_fix.rb:26:incall_with_invalid_char_handling' journey (1.0.4) lib/journey/router.rb:68:in block in call' journey (1.0.4) lib/journey/router.rb:56:ineach' journey (1.0.4) lib/journey/router.rb:56:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/routing/route_set.rb:601:incall' exception_notification (2.5.2) lib/exception_notifier.rb:25:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/best_standards_support.rb:17:incall' rack (1.4.3) lib/rack/etag.rb:23:in call' rack (1.4.3) lib/rack/conditionalget.rb:25:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/head.rb:14:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/params_parser.rb:21:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/flash.rb:242:in call' rack (1.4.3) lib/rack/session/abstract/id.rb:210:incontext' rack (1.4.3) lib/rack/session/abstract/id.rb:205:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/cookies.rb:341:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/callbacks.rb:28:in block in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:405:in_run4433636536728320701call4503962411421739686callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:405:in __run_callback' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:385:in_run_call_callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/callbacks.rb:81:in run_callbacks' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/callbacks.rb:27:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/remote_ip.rb:31:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:16:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/show_exceptions.rb:56:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/rack/logger.rb:32:incall_app' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/rack/logger.rb:16:in block in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/tagged_logging.rb:22:intagged' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/rack/logger.rb:16:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/actionpack/lib/action_dispatch/middleware/request_id.rb:22:incall' rack (1.4.3) lib/rack/methodoverride.rb:21:in call' rack (1.4.3) lib/rack/runtime.rb:17:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/activesupport/lib/active_support/cache/strategy/local_cache.rb:72:in call' rack (1.4.3) lib/rack/lock.rb:15:incall' rack-cache (1.2) lib/rack/cache/context.rb:136:in forward' rack-cache (1.2) lib/rack/cache/context.rb:245:infetch' rack-cache (1.2) lib/rack/cache/context.rb:185:in lookup' rack-cache (1.2) lib/rack/cache/context.rb:66:incall!' rack-cache (1.2) lib/rack/cache/context.rb:51:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/engine.rb:479:incall' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/application.rb:223:in call' /home/gt/web/shared/bundle/ruby/1.9.1/bundler/gems/rails-ec6db9257c53/railties/lib/rails/railtie/configurable.rb:30:inmethod_missing' unicorn (4.4.0) lib/unicorn/http_server.rb:535:in process_client' unicorn (4.4.0) lib/unicorn/http_server.rb:610:inworker_loop' unicorn (4.4.0) lib/unicorn/http_server.rb:491:in spawn_missing_workers' unicorn (4.4.0) lib/unicorn/http_server.rb:141:instart' unicorn (4.4.0) bin/unicorn:121:in <top (required)>' /home/gt/web/shared/bundle/ruby/1.9.1/bin/unicorn:23:inload' /home/gt/web/shared/bundle/ruby/1.9.1/bin/unicorn:23:in `

'

iceberg901 commented 11 years ago

Fixed with e3c7ed9942415f29b2a0fd6259c38e97f429a2b4