ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

Nonspecific error feedback from POST /roll/id/frames and GET video/find_or_create #174

Open iceberg901 opened 11 years ago

iceberg901 commented 11 years ago

This video:

http://vimeo.com/55899764

for some reason returns no info when put through embedly.

Likewise, it fails to generate meaningful data when its url is passed to GT::VideoManager.get_or_create_videos_for_url

As such, it generates 404 errors when submitted to

POST /roll/id/frames GET video/find_or_create

but the error info returned are not specific enough for a client of our api to know what went wrong or why. A client should be able to tell the user "Sorry, Vimeo does not support rolling that video to Shelby" instead of silently failing (which is what happens now on the bookmarklet/extension). But we don't want to do that on just any 404, only on 404s that are a direct result of this particular condition.

Request: These routes need to return specific information when this error occurs, along the lines of the fix we did for #152