search

ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

Shelby chat/email not putting multiple shares to the same user into the same conversation #188

Closed iceberg901 closed 11 years ago

iceberg901 commented 11 years ago

I sent two email shares to the same email address (josh@shelby.tv) which belongs to a shelby user, nickname is abe_feldstein, id is 4f901c9eb415cc540e000328.

Those two shares should have gone into one conversation, but when I visit shelby.tv/mail as the sending user, I see that they have been placed in two separate conversations.

Don't know if this is a contingent fact, but the sending user happened to be abe_feldstein, the same user who the shares were sent to.

spinosa commented 11 years ago

This is due to an edge case when sending to yourself.

Sending to a single other user does not encounter this.

spinosa commented 11 years ago

i'm deleting one of your bad rolls @iceberg901 so you can test my forthcoming fix