search

ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

Creator id for frame incoming from tumblr and frame's first convo message don't match #191

Closed iceberg901 closed 11 years ago

iceberg901 commented 11 years ago

http://api.shelby.tv/v1/frame/5114520e88ba6b63f41d3bdc?include_children=true

This frame appears to have come in from tumblr for our user shortformblog.

The creator of the frame is listed as id 51131dabb415cc1ded14402b, which can be verified in the db as being the user with nickname shortformblog and a tumblr auth.

The frame's convo has one message, which presumably is the message from tumblr when the the vid was ingested from there. The user_id on the message, however, is 4fa28d8c9a725b7a2a0001e4, which is not the id of any user in our DB.

spinosa commented 11 years ago

The references to an old User (id 51131dabb415cc1ded14402b) stop on Feb 7 2013. According to @ckurdziel it seems the actual user signed up around that date. Some merging may have taken place at this point, which would explain these oddities.

Evidence also in support: the authentication for the current shortformblog user was created May 3 2012, and its id is exactly 1 greater than the old User id referenced in these frame's messages.

New dev debt: When merging users, we need to update Frame's creator as well as creator_id referenced in Conversation.messages : #192