search

ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

Created rake task for updating the embedly regexes in the codebase, then... #203

Closed iceberg901 closed 11 years ago

iceberg901 commented 11 years ago

... ran it

@hsztul or @spinosa

Precursor to adding AOL ON is updating the embedly regexes. Can you verify that I got this right - ie that it's OK to add the new regexes before anything else is ready because even if we match the AOL videos we won't start adding them to the DB until I add logic to UrlHelper to start matching this provider? Thanks!

PS Since we're using the embedly API as the source of the regexes, I thought it was time we did this like big boys and parsed that info and updated the code in an automated fashion with a rake task, rather than with cut and paste and tedious manual editing to fix various escape sequences that are in parts of the information we don't even need. Thoughts?

hsztul commented 11 years ago

i believe you are correct. updating the embedly regexes wont add them to our db.

this regex is used to limit the number of calls we are making to embedly. so before, if we saw aol, we wouldnt have even asked embedly if the link was a video. now we will.

looks good to me!