search

ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

reece gets entries in his stream that seem like they shouldn't be there #206

Open iceberg901 opened 10 years ago

iceberg901 commented 10 years ago

user: reece - 4d7d154ff6db244f5e000001

dashboard entries: 524b41b6b415cc69d202163c, 524b418bb415cc75b40019a3

Reece seems to have gotten dashboard entries when he shared a video to his own roll and when he liked it (saving it to his watch later roll). This seems like something we used to do but I thought we weren't doing anymore.

@hsztul, @spinosa Did you think we were still creating db entries for a user when they performed these actions?

The video is id 5234599588ba6b214e07b658

Weird results on the front end, for example it dedupes in his stream and it shows him as both the sharer and a liker of the same video.

hsztul commented 10 years ago

Hmm. Without digging in too deep, if this was via the bookmarklet I could see this happening still maybe.

?

Henry On Oct 1, 2013 7:30 PM, "iceberg901" notifications@github.com wrote:

user: reece - 4d7d154ff6db244f5e000001

dashboard entries: 524b41b6b415cc69d202163c, 524b418bb415cc75b40019a3

Reece seems to have gotten dashboard entries when he shared a video to his own roll and when he liked it (saving it to his watch later roll). This seems like something we used to do but I thought we weren't doing anymore.

@hsztul https://github.com/hsztul, @spinosa https://github.com/spinosaDid you think we were still creating db entries for a user when they performed these actions?

The video is id 5234599588ba6b214e07b658

Weird results on the front end, for example it dedupes in his stream and it shows him as both the sharer and a liker of the same video.

— Reply to this email directly or view it on GitHubhttps://github.com/ShelbyTV/shelby_gt/issues/206 .

reecepacheco commented 10 years ago

was not via bookmarklet

::: reece pacheco ::: ceo, Shelby.tv http://shelby.tv/channels/trending ::: get the early news about our launch by following along on Facebookhttp://on.fb.me/182us0a and Twitter http://bit.ly/170riu6

On Wed, Oct 2, 2013 at 8:14 AM, Henry Sztul notifications@github.comwrote:

Hmm. Without digging in too deep, if this was via the bookmarklet I could see this happening still maybe.

?

Henry On Oct 1, 2013 7:30 PM, "iceberg901" notifications@github.com wrote:

user: reece - 4d7d154ff6db244f5e000001

dashboard entries: 524b41b6b415cc69d202163c, 524b418bb415cc75b40019a3

Reece seems to have gotten dashboard entries when he shared a video to his own roll and when he liked it (saving it to his watch later roll). This seems like something we used to do but I thought we weren't doing anymore.

@hsztul https://github.com/hsztul, @spinosa < https://github.com/spinosa>Did you think we were still creating db entries for a user when they performed these actions?

The video is id 5234599588ba6b214e07b658

Weird results on the front end, for example it dedupes in his stream and it shows him as both the sharer and a liker of the same video.

— Reply to this email directly or view it on GitHub< https://github.com/ShelbyTV/shelby_gt/issues/206> .

— Reply to this email directly or view it on GitHubhttps://github.com/ShelbyTV/shelby_gt/issues/206#issuecomment-25533555 .

spinosa commented 10 years ago

@iceberg901 both DashboardEntries are type 2 (new_in_app_frame) and they each have different Frames. From our comments in Frame.rb

  # N.B. when a Frame is duped (ie. to be put on WatchLater, Upvoted, or Viewed) we track the new Frame's ancestors, but do not add that new
  #      dupe Frame to the children of the original, as it's not a re-roll.

But neither frame has ancestors or children...

As far as I can tell, there are only two ways to end up with a type 2 dashboard entry: GT::Framer#backfill_dashboard_entries and FrameController#create. But you have to pass a video URL to FrameController#create to get a type 2 DBE, and you can't do that right now. So...

Did @reecepacheco re-follow himself, causing a backfill?