search

ShelbyTV / shelby_gt

Rails API services for Shelby GT
2 stars 0 forks source link

Liking is sharing #208

Closed hsztul closed 10 years ago

hsztul commented 10 years ago

This touches the Frame Model, GT::Framer, Frame Controller, and all associated tests.

@iceberg901 can go over in person to run through it all after lunch?

spinosa commented 10 years ago

please grab me after lunch @sztul, i'll join you guys to understand and review

danSpinosa.com shelby.tv/spinosa learn about your world

On Tue, Nov 26, 2013 at 10:59 AM, Henry Sztul notifications@github.comwrote:

This touches the Frame Model, GT::Framer, Frame Controller, and all associated tests.

@iceberg901 https://github.com/iceberg901 can go over in person to run

through it all after lunch?

You can merge this Pull Request by running

git pull https://github.com/ShelbyTV/shelby_gt liking-is-sharing

Or view, comment on, or merge it at:

https://github.com/ShelbyTV/shelby_gt/pull/208 Commit Summary

  • adding a type to frames and starting to follow the trail down the river
  • passing option to add frame type throught to create frame in framer
  • fixing broken tests
  • Merged in 'master'
  • adding frame type to view and enabling light weight share when creating a frame as an option
  • adding a comment

File Changes

  • M app/controllers/v1/discussion_roll_controller.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-0(68)
  • M app/controllers/v1/frame_controller.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-1(8)
  • M app/models/frame.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-2(18)
  • M app/views/v1/frame/show.json.rablhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-3(2)
  • M lib/gt/framer.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-4(30)
  • M spec/controllers/discussion_roll_controller_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-5(60)
  • M spec/controllers/frame_controller_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-6(1)
  • M spec/lib/gt/unit/framer_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-7(2)
  • M spec/models/functional/frame_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-8(76)
  • M spec/requests/v1/discussion_roll_integration_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-9(24)
  • M spec/requests/v1/frame_integration_spec.rbhttps://github.com/ShelbyTV/shelby_gt/pull/208/files#diff-10(18)

Patch Links: