upvote & undo-upvote should be idempotent

this seems related & simultaneously fixable:

A NoMethodError occurred in frame#upvote:

undefined method destroy' for nil:NilClass lib/gt/framer.rb:159:inremove_dupe_of_frame_from_roll!' ------------------------------- Request:

URL : http://api.gt.shelby.tv/v1/frame/4fdea6a49a725b476a0f6c29/upvote?undo=1&auth_token=sF7waBf8jBMqsxeskPp2
IP address: 68.50.220.207
Parameters: {"undo"=>"1", "auth_token"=>"sF7waBf8jBMqsxeskPp2", "format"=>"json", "action"=>"upvote", "controller"=>"v1/frame", "frame_id"=>"4fdea6a49a725b476a0f6c29"}
Rails root: /home/gt/api/releases/20120615214741 ------------------------------- Session:
session id: nil
data: {"warden.user.user.key"=> ["User", [BSON::ObjectId('4f6873a2ad9f11477f000124')], nil]} ------------------------------- Environment:
CONTENT_LENGTH : 0
DOCUMENT_ROOT : /home/gt/api/current/public
HTTPACCEPT : /_
HTTP_ACCEPT_ENCODING : gzip, deflate
HTTP_ACCEPT_LANGUAGE : en-us
HTTP_CONNECTION : keep-alive
HTTP_COOKIE : _shelby_gt_api_session=BAh7B0kiGXdhcmRlbi51c2VyLnVzZXIua2V5BjoGRVRbCEkiCVVzZXIGOwBGWwZvOhNCU09OOjpPYmplY3RJZAY6CkBkYXRhWxFpVGltaXhpAaJpAa1pAZ9pFmlMaQF%2FaQBpBmkpMEkiD3Nlc3Npb25faWQGOwBGSSIlZjJjY2NjOTc4ZGNmYzRlNWU1N2I2MzQ3OGI0MjhiMzkGOwBU--86eddafee6fbcd6b4ce6819d5cf305d59a87aca2; _shelby_gt_common=authenticated_user_id%3Dnil%2Ccsrf_token%3Dnil
HTTP_HOST : api.gt.shelby.tv
HTTP_IF_NONE_MATCH : "78600e7fc9fea77977263f7b7e513cac"
HTTP_ORIGIN :
HTTP_USER_AGENT : Shelby-tv/2.0a1 CFNetwork/592 Darwin/12.0.0
ORIGINAL_FULLPATH : /v1/frame/4fdea6a49a725b476a0f6c29/upvote?undo=1&auth_token=sF7waBf8jBMqsxeskPp2
PASSENGER_APP_SPAWNER_IDLE_TIME : -1
PASSENGER_APP_TYPE : rack
PASSENGER_CONNECT_PASSWORD : [FILTERED]
PASSENGER_DEBUGGER : false
PASSENGER_ENVIRONMENT : production
PASSENGER_FRAMEWORK_SPAWNER_IDLE_TIME : -1
PASSENGER_FRIENDLY_ERROR_PAGES : true
PASSENGER_GROUP :
PASSENGER_MAX_REQUESTS : 0
PASSENGER_MIN_INSTANCES : 1
PASSENGER_SHOW_VERSION_IN_HEADER : true
PASSENGER_SPAWN_METHOD : smart-lv2
PASSENGER_USER :
PASSENGER_USE_GLOBAL_QUEUE : true
PATH_INFO : /v1/frame/4fdea6a49a725b476a0f6c29/upvote
QUERY_STRING : undo=1&auth_token=sF7waBf8jBMqsxeskPp2
REMOTE_ADDR : 68.50.220.207
REMOTE_PORT : 50859
REQUEST_METHOD : POST
REQUEST_URI : /v1/frame/4fdea6a49a725b476a0f6c29/upvote?undo=1&auth_token=sF7waBf8jBMqsxeskPp2
SCGI : 1
SCRIPT_NAME :
SERVER_ADDR : 108.166.56.26
SERVER_NAME : api.gt.shelby.tv
SERVER_PORT : 80
SERVER_PROTOCOL : HTTP/1.1
SERVER_SOFTWARE : nginx/1.0.10
UNION_STATION_SUPPORT : false
:
action_controller.instance : frame#upvote
action_dispatch.backtrace_cleaner : #Rails::BacktraceCleaner:0x00000003498c40
action_dispatch.cookies : #ActionDispatch::Cookies::CookieJar:0x000000057159a8
action_dispatch.logger : #ActiveSupport::TaggedLogging:0x0000000254dfd8
action_dispatch.parameter_filter : [:password, /RAW_POST_DATA/]
action_dispatch.remote_ip : 68.50.220.207
action_dispatch.request.content_type :
action_dispatch.request.flash_hash :
action_dispatch.request.formats : [application/json]
action_dispatch.request.parameters : {"undo"=>"1", "auth_token"=>"sF7waBf8jBMqsxeskPp2", "format"=>"json", "action"=>"upvote", "controller"=>"v1/frame", "frame_id"=>"4fdea6a49a725b476a0f6c29"}
action_dispatch.request.path_parameters : {:format=>"json", :action=>"upvote", :controller=>"v1/frame", :frame_id=>"4fdea6a49a725b476a0f6c29"}
action_dispatch.request.query_parameters : {"undo"=>"1", "auth_token"=>"sF7waBf8jBMqsxeskPp2"}
action_dispatch.request.request_parameters : {}
action_dispatch.request.unsigned_session_cookie: {"warden.user.user.key"=>["User", [BSON::ObjectId('4f6873a2ad9f11477f000124')], nil], "session_id"=>"f2cccc978dcfc4e5e57b63478b428b39"}
action_dispatch.request_id : 6fa7716d849685caf30b196d88d6554e
action_dispatch.routes : #ActionDispatch::Routing::RouteSet:0x00000002acb3c0
action_dispatch.secret_token : bf4cd3afd9fe651da3536bead5e415ca5fff75142c716df3deb6fd537be93eea3e8deb5cf25bd4c36267714bc65a1911466e8afda86b09220636b074355eb68d
action_dispatch.show_detailed_exceptions : false
action_dispatch.show_exceptions : true
exception_notifier.options : {:sender_address=>"\"ShelbyGT Notifier\" whatever-noreply@shelby.com", :exception_recipients=>["gt-api-errors@shelby.tv"], :email_prefix=>"[GT Backend Error] ", :sections=>["request", "session", "environment", "backtrace"], :ignore_exceptions=>[AbstractController::ActionNotFound, ActionController::RoutingError]}
rack-cache.allow_reload : false
rack-cache.allow_revalidate : false
rack-cache.cache_key : Rack::Cache::Key
rack-cache.default_ttl : 0
rack-cache.entitystore : rails:/
rack-cache.ignore_headers : ["Set-Cookie"]
rack-cache.metastore : rails:/
rack-cache.private_headers : ["Authorization", "Cookie"]
rack-cache.storage : #Rack::Cache::Storage:0x00000003156cd0
rack-cache.use_native_ttl : false
rack-cache.verbose : true
rack.errors : #IO:0x00000000745220
rack.input : #PhusionPassenger::Utils::RewindableInput:0x000000051c8608
rack.multiprocess : true
rack.multithread : false
rack.request.cookie_hash : {"_shelby_gt_api_session"=>"BAh7B0kiGXdhcmRlbi51c2VyLnVzZXIua2V5BjoGRVRbCEkiCVVzZXIGOwBGWwZvOhNCU09OOjpPYmplY3RJZAY6CkBkYXRhWxFpVGltaXhpAaJpAa1pAZ9pFmlMaQF/aQBpBmkpMEkiD3Nlc3Npb25faWQGOwBGSSIlZjJjY2NjOTc4ZGNmYzRlNWU1N2I2MzQ3OGI0MjhiMzkGOwBU--86eddafee6fbcd6b4ce6819d5cf305d59a87aca2", "_shelby_gt_common"=>"authenticated_user_id=nil,csrf_token=nil"}
rack.request.cookie_string : _shelby_gt_api_session=BAh7B0kiGXdhcmRlbi51c2VyLnVzZXIua2V5BjoGRVRbCEkiCVVzZXIGOwBGWwZvOhNCU09OOjpPYmplY3RJZAY6CkBkYXRhWxFpVGltaXhpAaJpAa1pAZ9pFmlMaQF%2FaQBpBmkpMEkiD3Nlc3Npb25faWQGOwBGSSIlZjJjY2NjOTc4ZGNmYzRlNWU1N2I2MzQ3OGI0MjhiMzkGOwBU--86eddafee6fbcd6b4ce6819d5cf305d59a87aca2; _shelby_gt_common=authenticated_user_id%3Dnil%2Ccsrf_token%3Dnil
rack.request.form_hash : {}
rack.request.form_input : #PhusionPassenger::Utils::RewindableInput:0x000000051c8608
rack.request.form_vars :
rack.request.query_hash : {"undo"=>"1", "auth_token"=>"sF7waBf8jBMqsxeskPp2"}
rack.request.query_string : undo=1&auth_token=sF7waBf8jBMqsxeskPp2
rack.run_once : false
rack.session : {"warden.user.user.key"=>["User", [BSON::ObjectId('4f6873a2ad9f11477f000124')], nil]}
rack.session.options : {:path=>"/", :domain=>".shelby.tv", :expire_after=>nil, :secure=>false, :httponly=>true, :defer=>false, :renew=>true, :coder=>#Rack::Session::Cookie::Base64::Marshal:0x000000015ffba8, :id=>nil}
rack.url_scheme : http
rack.version : [1, 0]
warden : Warden::Proxy:45654500 @config={:default_scope=>:user, :scope_defaults=>{}, :default_strategies=>{:user=>[:rememberable, :token_authenticatable]}, :intercept_401=>false, :failure_app=>#Devise::Delegator:0x000000034feb08}
Process: 25424
Server : gt-api-a ------------------------------- Backtrace:

lib/gt/framer.rb:159:in remove_dupe_of_frame_from_roll!' app/models/frame.rb:139:inupvote_undo!' app/controllers/v1/frame_controller.rb:392:in block in upvote' lib/stats/stats_manager.rb:35:intime' app/controllers/v1/frame_controller.rb:387:in upvote' actionpack (3.2.2) lib/action_controller/metal/implicit_render.rb:4:insend_action' actionpack (3.2.2) lib/abstract_controller/base.rb:167:in process_action' actionpack (3.2.2) lib/action_controller/metal/rendering.rb:10:inprocess_action' actionpack (3.2.2) lib/abstract_controller/callbacks.rb:18:in block in process_action' activesupport (3.2.2) lib/active_support/callbacks.rb:436:in_run3146261660570648742process_action3359774308037667786callbacks' activesupport (3.2.2) lib/active_support/callbacks.rb:405:in __run_callback' activesupport (3.2.2) lib/active_support/callbacks.rb:385:in_run_process_action_callbacks' activesupport (3.2.2) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.2.2) lib/abstract_controller/callbacks.rb:17:inprocess_action' actionpack (3.2.2) lib/action_controller/metal/rescue.rb:29:in process_action' actionpack (3.2.2) lib/action_controller/metal/instrumentation.rb:30:inblock in process_action' activesupport (3.2.2) lib/active_support/notifications.rb:123:in block in instrument' activesupport (3.2.2) lib/active_support/notifications/instrumenter.rb:20:ininstrument' activesupport (3.2.2) lib/active_support/notifications.rb:123:in instrument' actionpack (3.2.2) lib/action_controller/metal/instrumentation.rb:29:inprocess_action' actionpack (3.2.2) lib/action_controller/metal/params_wrapper.rb:205:in process_action' newrelic_rpm (3.3.5) lib/new_relic/agent/instrumentation/rails3/action_controller.rb:34:inblock in process_action' newrelic_rpm (3.3.5) lib/new_relic/agent/instrumentation/controller_instrumentation.rb:257:in block in perform_action_with_newrelic_trace' newrelic_rpm (3.3.5) lib/new_relic/agent/method_tracer.rb:242:intrace_execution_scoped' newrelic_rpm (3.3.5) lib/new_relic/agent/instrumentation/controller_instrumentation.rb:252:in perform_action_with_newrelic_trace' newrelic_rpm (3.3.5) lib/new_relic/agent/instrumentation/rails3/action_controller.rb:33:inprocess_action' actionpack (3.2.2) lib/abstract_controller/base.rb:121:in process' actionpack (3.2.2) lib/abstract_controller/rendering.rb:45:inprocess' actionpack (3.2.2) lib/action_controller/metal.rb:203:in dispatch' actionpack (3.2.2) lib/action_controller/metal/rack_delegation.rb:14:indispatch' actionpack (3.2.2) lib/action_controller/metal.rb:246:in block in action' actionpack (3.2.2) lib/action_dispatch/routing/route_set.rb:67:incall' actionpack (3.2.2) lib/action_dispatch/routing/route_set.rb:67:in dispatch' actionpack (3.2.2) lib/action_dispatch/routing/route_set.rb:30:incall' journey (1.0.3) lib/journey/router.rb:68:in block in call' journey (1.0.3) lib/journey/router.rb:56:ineach' journey (1.0.3) lib/journey/router.rb:56:in call' actionpack (3.2.2) lib/action_dispatch/routing/route_set.rb:594:incall' omniauth (1.0.3) lib/omniauth/strategy.rb:168:in call!' omniauth (1.0.3) lib/omniauth/strategy.rb:148:incall' omniauth (1.0.3) lib/omniauth/strategy.rb:168:in call!' omniauth (1.0.3) lib/omniauth/strategy.rb:148:incall' omniauth (1.0.3) lib/omniauth/strategy.rb:168:in call!' omniauth (1.0.3) lib/omniauth/strategy.rb:148:incall' omniauth (1.0.3) lib/omniauth/builder.rb:42:in call' exception_notification (2.5.2) lib/exception_notifier.rb:25:incall' newrelic_rpm (3.3.5) lib/new_relic/rack/browser_monitoring.rb:12:in call' rack-oauth2-server (2.6.0) lib/rack/oauth2/server.rb:272:incall' /home/gt/.rvm/gems/ruby-1.9.3-p125/bundler/gems/mongomapper-f856b5d6c85b/lib/mongo_mapper/middleware/identity_map.rb:10:in call' sass (3.1.15) lib/sass/plugin/rack.rb:54:incall' rack-cors (0.2.4) lib/rack/cors.rb:51:in call' warden (1.1.1) lib/warden/manager.rb:35:inblock in call' warden (1.1.1) lib/warden/manager.rb:34:in catch' warden (1.1.1) lib/warden/manager.rb:34:incall' actionpack (3.2.2) lib/action_dispatch/middleware/best_standards_support.rb:17:in call' rack (1.4.1) lib/rack/etag.rb:23:incall' rack (1.4.1) lib/rack/conditionalget.rb:35:in call' actionpack (3.2.2) lib/action_dispatch/middleware/head.rb:14:incall' actionpack (3.2.2) lib/action_dispatch/middleware/params_parser.rb:21:in call' actionpack (3.2.2) lib/action_dispatch/middleware/flash.rb:242:incall' rack (1.4.1) lib/rack/session/abstract/id.rb:205:in context' rack (1.4.1) lib/rack/session/abstract/id.rb:200:incall' actionpack (3.2.2) lib/action_dispatch/middleware/cookies.rb:338:in call' actionpack (3.2.2) lib/action_dispatch/middleware/callbacks.rb:28:inblock in call' activesupport (3.2.2) lib/active_support/callbacks.rb:405:in _run__1482501248003686213__call__3649713428287851125__callbacks' activesupport (3.2.2) lib/active_support/callbacks.rb:405:in__run_callback' activesupport (3.2.2) lib/active_support/callbacks.rb:385:in _run_call_callbacks' activesupport (3.2.2) lib/active_support/callbacks.rb:81:inrun_callbacks' actionpack (3.2.2) lib/action_dispatch/middleware/callbacks.rb:27:in call' actionpack (3.2.2) lib/action_dispatch/middleware/remote_ip.rb:31:incall' actionpack (3.2.2) lib/action_dispatch/middleware/debug_exceptions.rb:16:in call' actionpack (3.2.2) lib/action_dispatch/middleware/show_exceptions.rb:56:incall' railties (3.2.2) lib/rails/rack/logger.rb:26:in call_app' railties (3.2.2) lib/rails/rack/logger.rb:16:incall' actionpack (3.2.2) lib/action_dispatch/middleware/request_id.rb:22:in call' rack (1.4.1) lib/rack/methodoverride.rb:21:incall' rack (1.4.1) lib/rack/runtime.rb:17:in call' activesupport (3.2.2) lib/active_support/cache/strategy/local_cache.rb:72:incall' rack (1.4.1) lib/rack/lock.rb:15:in call' rack-cache (1.2) lib/rack/cache/context.rb:136:inforward' rack-cache (1.2) lib/rack/cache/context.rb:143:in pass' rack-cache (1.2) lib/rack/cache/context.rb:155:ininvalidate' rack-cache (1.2) lib/rack/cache/context.rb:71:in call!' rack-cache (1.2) lib/rack/cache/context.rb:51:incall' railties (3.2.2) lib/rails/engine.rb:479:in call' railties (3.2.2) lib/rails/application.rb:220:incall' railties (3.2.2) lib/rails/railtie/configurable.rb:30:in method_missing' passenger (3.0.11) lib/phusion_passenger/rack/request_handler.rb:96:inprocess_request' passenger (3.0.11) lib/phusion_passenger/abstract_request_handler.rb:513:in accept_and_process_next_request' passenger (3.0.11) lib/phusion_passenger/abstract_request_handler.rb:274:inmain_loop' passenger (3.0.11) lib/phusion_passenger/rack/application_spawner.rb:206:in start_request_handler' passenger (3.0.11) lib/phusion_passenger/rack/application_spawner.rb:171:inblock in handle_spawn_application' passenger (3.0.11) lib/phusion_passenger/utils.rb:479:in safe_fork' passenger (3.0.11) lib/phusion_passenger/rack/application_spawner.rb:166:inhandle_spawn_application' passenger (3.0.11) lib/phusion_passenger/abstract_server.rb:357:in server_main_loop' passenger (3.0.11) lib/phusion_passenger/abstract_server.rb:206:instart_synchronously' passenger (3.0.11) lib/phusion_passenger/abstract_server.rb:180:in start' passenger (3.0.11) lib/phusion_passenger/rack/application_spawner.rb:129:instart' passenger (3.0.11) lib/phusion_passenger/spawn_manager.rb:253:in block (2 levels) in spawn_rack_application' passenger (3.0.11) lib/phusion_passenger/abstract_server_collection.rb:132:inlookup_or_add' passenger (3.0.11) lib/phusion_passenger/spawn_manager.rb:246:in block in spawn_rack_application' passenger (3.0.11) lib/phusion_passenger/abstract_server_collection.rb:82:inblock in synchronize' internal:prelude:10:in synchronize' passenger (3.0.11) lib/phusion_passenger/abstract_server_collection.rb:79:insynchronize' passenger (3.0.11) lib/phusion_passenger/spawn_manager.rb:244:in spawn_rack_application' passenger (3.0.11) lib/phusion_passenger/spawn_manager.rb:137:inspawn_application' passenger (3.0.11) lib/phusion_passenger/spawn_manager.rb:275:in handle_spawn_application' passenger (3.0.11) lib/phusion_passenger/abstract_server.rb:357:inserver_main_loop' passenger (3.0.11) lib/phusion_passenger/abstract_server.rb:206:in start_synchronously' passenger (3.0.11) helper-scripts/passenger-spawn-server:99:in

ShelbyTV / shelby_gt

upvote & undo-upvote should be idempotent #82