Sheldan / abstracto

Discord Bot Base
MIT License
5 stars 1 forks source link

Transactions do not behave correctly when using a runtime exception in new async operations #54

Open Sheldan opened 2 years ago

Sheldan commented 2 years ago

General Troubleshooting

Description

The reason for this is that Transactional only rollsback for checked exceptions. We need to add the AbstractoRunTimeException to this as well in all places.

Steps to reproduce

Have a command fail in an unexpected way with a runtime exception.

Expected behaviour

Any result should not be persisted

Actual behaviour

Results in sub-transactional blocks are still persisted.