[Bug]: Cannot Asset to an Unavailable Kit (Although the Kit is available)

Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.

https://shelf.nu

GNU Affero General Public License v3.0

1.78k stars 158 forks source link

[Bug]: Cannot Asset to an Unavailable Kit (Although the Kit is available) #1069

Closed carlosvirreira closed 3 months ago

carlosvirreira commented 3 months ago

Contact Details

No response

What happened?

https://github.com/Shelf-nu/shelf.nu/assets/12449255/b09f7d34-de3b-4437-a10b-ccef21cbf8e0

Fair warning: These kits were added to a Booking which is on Reserved State. Not on Checked out state.

What is the expected behaviour?

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Safari

Relevant log output

No response

DonKoko commented 3 months ago

@carlosvirreira a fix for this is being deployed: https://github.com/Shelf-nu/shelf.nu/actions/runs/9582473645

I made sure that you can still add assets if the status is reserved. I also implemented a check also on the front-end so the manage assets button is disabled if any related bookings are ongoing.