search

Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.
https://shelf.nu
GNU Affero General Public License v3.0
1.67k stars 145 forks source link

Feature/asset booking tab #1070

Closed rockingrohit9639 closed 4 weeks ago

rockingrohit9639 commented 4 weeks ago

Fix - #1058

DonKoko commented 4 weeks ago

@carlosvirreira @jurrejansen this is deployed to staging and ready to test. I have tested both ADMIN and SELF SERVICE users and everything seems good.

carlosvirreira commented 4 weeks ago

Bugs / Things to look at: Self Service User

As a self service user I get an error when trying to make a booking. The error reads 'You are not authorized to view this booking'

When I make a booking, due to my permission level I cannot select another custodian. This is fine. However, the field is empty and can be perceived as a bug when it is not.

DonKoko commented 4 weeks ago

Bugs / Things to look at: Self Service User

As a self service user I get an error when trying to make a booking. The error reads 'You are not authorized to view this booking'

When I make a booking, due to my permission level I cannot select another custodian. This is fine. However, the field is empty and can be perceived as a bug when it is not.

Okey this bug happens because the user you used to test is corrupted. That user was created when we still had a bug that we were not creating team members for normal users. This has already been resolved. Also this bug is not related to this branch at all. Its related to the SSO branch so irrelevant for this PR.

If thats the only thing, we can safely merge this branch.