search

Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.
https://shelf.nu
GNU Affero General Public License v3.0
1.67k stars 145 forks source link

[Feature request]: Option to filter asset index on 'Uncategorized' assets #1074

Closed jurrejansen closed 3 weeks ago

jurrejansen commented 4 weeks ago

Contact Details

jurre@shelf.nu

Is your feature request related to a problem? Please describe?

A user commented that they would like the option of filtering the index on 'Uncategorized' assets. This basically means they want to have a filtered state of the asset index that shows all the assets that currently don't have a category assigned.

Describe the solution you'd like

Adding a 'No category' or 'Without category' option in the Category filter. I have created a separation between the normal entries within the dropdown list and the 'No category' option

Screenshot 2024-06-19 at 13 09 41

If selected only assets that have no category assigned will show. This UX is inspired by the ability to filter on time entries that have no project assigned within a Clockify environment.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/841195bd-2505-4037-9e31-82c4e1828d17

You can find the artboards needed here: https://www.figma.com/design/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?node-id=6244-36394

OPTIONAL

Also implement a 'Select all' option so a user can select all categories and easily filter out categories they don't want to see.

Screenshot 2024-06-19 at 12 55 05

https://github.com/Shelf-nu/shelf.nu/assets/76112272/bf6e7ab5-6d32-4f48-aa18-10fadfa10982

Additionally, we could go the extra mile and also implement this for Tags, Location and Custodian.

Screenshot 2024-06-19 at 13 05 23

Screenshot 2024-06-19 at 13 05 23

Describe alternatives you've considered

No response

Additional context

No response

jurrejansen commented 4 weeks ago

Hi @DonKoko let me know if you would like me to spend time on an actual scenario for this

DonKoko commented 4 weeks ago

@jurrejansen thanks man. I don't have time to review it today but will do as soon as I can and will let you know.

@rockingrohit9639 can you also please review this request and lmk if you see any issues with how it will work with our model filters. Any feedback is appreciated.

rockingrohit9639 commented 4 weeks ago

@DonKoko I think we can push a hardcoded category "Without Category" option in items. And we can have a condition to do filtering accordingly.

DonKoko commented 4 weeks ago

@rockingrohit9639 yeah I think thats fine as we need it only on the indecies where the DynamicDropdown is used for filtering. We also have to consider the visuals and that it has this little extra space below.

DonKoko commented 3 weeks ago

@jurrejansen @carlosvirreira this is released to live: https://github.com/Shelf-nu/shelf.nu/actions/runs/9643417420 I am however not convinced about the "Select all" thing. Is it something requested by our users? I get the use case but I think its so super edge and unless its been requested by our users, I wouldnt give it such high value real estate. LMK what you think.