Feature - Bulk actions

[rockingrohit9639]

PR - #397

[DonKoko]

Okey man, I took the time to make some changes to the code. I have made the new header with handling the title and the selected count and everything so we can go forward. Here is what you should do for the assets index:

• [x] Create an bulk-actions-dropdown
• [x] Create the functions and add the basic actions we want to start with
  • [x] Check out
  • [x] Check in
  • [x] Update Location
  • [x] Update category
  • [x] Delete

[DonKoko]

@carlosvirreira @jurrejansen pushed to testapp and ready to be tested. I tested everything but please take a look and lmk what your feedback is. Then we can release it and look into implementing bulk actions on other views as well.

[jurrejansen]

• [ ] Is the little X button that appears when using bulk selection necessary? As far I can see the same can be achieved with the checkbox at the very top and I would remove it. But maybe I am missing something and it was put there for a reason.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/76cfe68b-d0a5-4d94-bb19-028b28a8ae32

• [x] After performing a bulk Delete action, bulk selection seems to be not working anymore. When you select assets and click the Actions button the assets get deselected.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/beb8fb3e-01be-444e-a89a-2aba41189a2e https://github.com/Shelf-nu/shelf.nu/assets/76112272/b5fab5eb-b1a2-42b8-ade8-dd2d115ea7d8

• [x] Can we separate the Delete action from the rest. Would like to see the options separated. like in the screenshot below

[carlosvirreira]

@jurrejansen

I'd leave the X as it is super practical. To be honest I did not even notice the other element. I can imagine that to move all that logic 'down there' is considerable work and will block the release.

[jurrejansen]

@carlosvirreira the logic is already there but I'll leave it up to y'all

https://github.com/Shelf-nu/shelf.nu/assets/76112272/24163ac8-d7a4-4031-8633-9748a067113d

[carlosvirreira]

• Bulk checking in assets work only if you have 1 page selected
• In some cases after performing bulk action selection gets reset https://github.com/Shelf-nu/shelf.nu/assets/12449255/2b6fa677-043f-4e47-b525-c664b688441b
• Batch assigning assets fails if selecting 1 page (with filter available applied) https://github.com/Shelf-nu/shelf.nu/assets/12449255/aff0d364-b814-419e-8f5e-6419e574d61d
• Deleting mixed works without warning Uploading Screen Recording 2024-07-01 at 11.33.57.mov…
• This deleted all assets (warning said delete 21) (you can see I had assets on category 'Supplies') - after that, I got left nothing. https://github.com/Shelf-nu/shelf.nu/assets/12449255/38f35f1c-3aa0-43a1-8a2a-5d075ab6fcb0

[DonKoko]

Is the little X button that appears when using bulk selection necessary? As far I can see the same can be achieved with the checkbox at the very top and I would remove it. But maybe I am missing something and it was put there for a reason.

Yes we know it can be done via the normal button. I wanted to add an explicit action as that makes it way easier for some users.

@rockingrohit9639 can you look at the rest of the issues.

[carlosvirreira]

[ ]Filtering by available, selecting two pages of assets and assigning to one person generates error. https://github.com/Shelf-nu/shelf.nu/assets/12449255/0bf98832-04e6-43b4-a6c1-4d2dabe1622a

[ ] Filtering by available, selecting one page and assigning to one person works. https://github.com/Shelf-nu/shelf.nu/assets/12449255/a703091e-e4e2-4de8-8a01-8c4f91bd7c1d

[jurrejansen]

• [ ] I think after performing a bulk action the entries that were selected should be deselected afterwards https://github.com/Shelf-nu/shelf.nu/assets/76112272/256f655c-cc43-4c56-aba5-a3ad50682b24

• [x] Small thing, I think the Clear button in the Update Location modal should not be displayed when the modal appears due to performing a Bulk Action. Because there won't be a location to clear ever. https://github.com/Shelf-nu/shelf.nu/assets/76112272/59b978ec-4c34-411d-bbb5-384ea4bcf768

• [x] Bulk selecting assets in the asset index is impacting the table header of other indexes. I feel like bulk selections shouldn't have to be saved anyways when you move away from a page with an index and navigating back. https://github.com/Shelf-nu/shelf.nu/assets/76112272/47e3525d-755f-4b98-ba59-ab9fcc66dd08

• [x] When I select a combination assets and asset that are part of a kit the dropdown gives me a disclaimer that some actions are disabled but none are. https://github.com/Shelf-nu/shelf.nu/assets/76112272/008e45f3-2e3a-4203-bdef-5d83d500e0d7

• [x] When selecting All assets and performing the Delete action the modal is showing me an incorrect number of selected assets. However, it will delete everything after Confirming https://github.com/Shelf-nu/shelf.nu/assets/76112272/e81ab858-489a-46a5-bc4b-9d7e1f0b1e32

[DonKoko]

I think after performing a bulk action the entries that were selected should be deselected afterwards

Carlos gave the opposite feedback of this. I did a little research, namely i checked how supabase does it. They keep the selection so I took the decision to do it that way. I am not 100% sure if thats the best, I think its a judgement call. Lets wait and see how our users react to this. We can easy change it later.