Feature/kit bulk action

Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.

https://shelf.nu

GNU Affero General Public License v3.0

1.65k stars 145 forks source link

Feature/kit bulk action #1127

Closed rockingrohit9639 closed 3 days ago

rockingrohit9639 commented 4 days ago

PR - #1120

DonKoko commented 3 days ago

change how disabled actions are managed: 46210ed

remove generic messages from dropdown
use the reverse logic, so instead of checking if some are available check if all are available
implement a hover card inside the trigger to show disabled messages
allow disabled to be either boolean or object

DonKoko commented 3 days ago

@carlosvirreira @jurrejansen bulk actions for kits are deploying to staging (https://github.com/Shelf-nu/shelf.nu/actions/runs/9791067104) Can you please test them and lmk if you find any issues.

FYI, we have adjusted how the disabled states and messages look. We dont have the generic messages anymore, now depending on the case, when you hover an item it will show you specifically why it is disabled. Way better UX for the users and more clear communication.

carlosvirreira commented 3 days ago

My batch action tests for kits were all successful.

jurrejansen commented 3 days ago

[x] There's unnecessary space between checkbox and asset thumbnail
[x] When one or more assets in a kit are not available the Assign custody action is disabled on Kit page. However when doing bulk action is is not disabled and you get error when trying to confirm in the Assign custody modal. Better to also disable the action and use the new UX with extra tool tip.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/767bdcb4-5ce1-4930-a9c9-b90fa0046ef3