Shelf-nu / shelf.nu

shelf is open source Asset Management Infrastructure for absolutely everyone.
https://shelf.nu
GNU Affero General Public License v3.0
1.83k stars 172 forks source link

[Bug]: Scaning QR does't ask and record location #804

Closed DonKoko closed 6 months ago

DonKoko commented 8 months ago

Contact Details

No response

What happened?

Steps to reproduce:

  1. Scan a QR
  2. Notice is the browser asks for permissions.

This has been reported by a shelf user. They are having this issue only on chrome, both in pwa and browser mode. I asked the user some questions and this is the input:

What device do you use?

OnePlus Nord 2T 5G

Can you check which version of Chrome you use? 122.0.6261.64

Did you try in another browser(just so we can validate if its a browser or device issue) I have logged in using Firefox and I can confirm that the location is now displaying after scanning! 😊

Did you get the popup for permissions for sharing location? I know you said the permissions are there but I am wondering if you get the popup. On theory it should pop-up every time. I don’t get a pop-up or any prompt to give permission to share location.

Are you using shelf directly from the website or you added it to your homescreen? Previously was Shelf.nu added to the homescreen using Chrome. Above test was using Firefox in browser.

Can you try resetting the permissions for shelf.nu and then scan again? You should get a popup for sharing location. I did try this for Chrome but no effect. Could be the fact I am launching from a bookmark on my homescreen?

What is the expected behaviour?

Browser should ask for permissions

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

DonKoko commented 8 months ago

I can't recreate that. I have asked the user to help with debugging/testing this. Waiting for response

DonKoko commented 7 months ago

This should be resolved by the updates to the scanner. Waiting for response from the user who had the issue.

jurrejansen commented 6 months ago

Will get solved by completing https://github.com/Shelf-nu/shelf.nu/issues/914