[Bug]: Updating an asset image doesn't delete the old image

[DonKoko]

Contact Details

No response

What happened?

Steps to reproduce:

1. Go to an asset
2. Edit the asset and change its image
3. Go to supabase and check storage folder
4. Notice that the old image is not deleted

What is the expected behaviour?

The old image should get deleted. We have to only do that if the upload of the new image was successful.

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

[DonKoko]

/bounty 10

[algora-pbc[bot]]

💎 $10 bounty • Shelf

Steps to solve:

1. Start working: Comment /attempt #884 with your implementation plan
2. Submit work: Create a pull request including /claim #884 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to Shelf-nu/shelf.nu!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🟢 @rajeshj11	Jun 10, 2024, 12:53:20 PM	#1045

[rajesh-jonnalagadda]

/attempt #884

Algora profile	Completed bounties	Tech	Active attempts	Options
@rajeshj11	1 Shelf-nu bounty + 3 bounties from 2 projects	JavaScript, TypeScript, HTML	﹟1018	Cancel attempt

[algora-pbc[bot]]

💡 @rajeshj11 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

[DonKoko]

Has been resolved. Old images are now deleted. Also we make sure that if it fails the Logger will send the error to Sentry so we can keep track.

[algora-pbc[bot]]

🎉🎈 @rajeshj11 has been awarded $10! 🎈🎊

• Share on socials
• Give feedback